Discussion:
[Audacity-devel] What is CrossFade.cpp for?
Paul Licameli
2016-08-26 15:55:15 UTC
Permalink
Does anyone have any recollections as the purpose of the class CrossFader,
implemented in CrossFade.cpp, but not now used anywhere?

I haven't read it all but I see some horrible things in it that could not
possibly have worked. Such as the casts of Sequence* as int* and short*.

This was incidental to finding the unsafe narrowings of sampleCount, which
happen in here too, when sampleCounts are used as array subscripts.

Can this file just be trashed?

PRL
Steve the Fiddle
2016-08-26 16:21:02 UTC
Permalink
I'd guess that it was this proposed new feature:
http://wiki.audacityteam.org/wiki/Proposal_Crossfade
That proposal remains a valid proposal.
Are you saying that there is "nothing" worth keeping from that code?

Steve
Post by Paul Licameli
Does anyone have any recollections as the purpose of the class CrossFader,
implemented in CrossFade.cpp, but not now used anywhere?
I haven't read it all but I see some horrible things in it that could not
possibly have worked. Such as the casts of Sequence* as int* and short*.
This was incidental to finding the unsafe narrowings of sampleCount, which
happen in here too, when sampleCounts are used as array subscripts.
Can this file just be trashed?
PRL
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Paul Licameli
2016-08-26 16:26:53 UTC
Permalink
Post by Steve the Fiddle
http://wiki.audacityteam.org/wiki/Proposal_Crossfade
That proposal remains a valid proposal.
Are you saying that there is "nothing" worth keeping from that code?
Steve
I can't make that judgment yet, I haven't read the whole thing, but I do
see some shockingly wrong things in this unused class. But it may be worth
keeping around for some reasons of future development.

PRL
Post by Steve the Fiddle
Post by Paul Licameli
Does anyone have any recollections as the purpose of the class
CrossFader, implemented in CrossFade.cpp, but not now used anywhere?
I haven't read it all but I see some horrible things in it that could not
possibly have worked. Such as the casts of Sequence* as int* and short*.
This was incidental to finding the unsafe narrowings of sampleCount,
which happen in here too, when sampleCounts are used as array subscripts.
Can this file just be trashed?
PRL
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Steve the Fiddle
2016-08-26 18:30:53 UTC
Permalink
On Fri, Aug 26, 2016 at 12:21 PM, Steve the Fiddle <
Post by Steve the Fiddle
http://wiki.audacityteam.org/wiki/Proposal_Crossfade
That proposal remains a valid proposal.
Are you saying that there is "nothing" worth keeping from that code?
Steve
I can't make that judgment yet, I haven't read the whole thing, but I do
see some shockingly wrong things in this unused class. But it may be worth
keeping around for some reasons of future development.
Perhaps the most useful thing to do without wasting too much time on it is
to just add some comments, then leave as is.

Steve
PRL
Post by Steve the Fiddle
Post by Paul Licameli
Does anyone have any recollections as the purpose of the class
CrossFader, implemented in CrossFade.cpp, but not now used anywhere?
I haven't read it all but I see some horrible things in it that could
not possibly have worked. Such as the casts of Sequence* as int* and
short*.
This was incidental to finding the unsafe narrowings of sampleCount,
which happen in here too, when sampleCounts are used as array subscripts.
Can this file just be trashed?
PRL
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Loading...