[Audacity-devel] James caused a very bad change in appearance of export dialog on Mac

Discussion:

Paul Licameli

2016-12-27 14:56:09 UTC

I am running MacOs 10.11.6.

If I build present head and generate sound, and Export Audio, then I get a
Save dialog that does not as previously have an upper pane allowing
selection of a destination folder, and if I select MP3 Files as file type,
then the options pane below is sized too narrow. The rightmost of the
radio buttons for Bit Rate Mode shows only a semicircle and has no
caption. The dialog cannot be resized.

I bisected this to this recent commit, which changed no source code:

commit c493e38a688700208c0ddffc44b7523fca30451b

Author: James Crook <***@gmail.com>

Date: Mon Dec 12 18:12:35 2016 +0000

Use org.audacityteam.audacty

Gale Andrews

2016-12-27 15:32:28 UTC

Permalink

I am not seeing that on macOS Sierra10.12.2 on a 1280*1024 monitor.

Release build of HEAD built yesterday.

Gale

Post by Paul Licameli
I am running MacOs 10.11.6.
If I build present head and generate sound, and Export Audio, then I get a
Save dialog that does not as previously have an upper pane allowing
selection of a destination folder, and if I select MP3 Files as file type,
then the options pane below is sized too narrow. The rightmost of the radio
buttons for Bit Rate Mode shows only a semicircle and has no caption. The
dialog cannot be resized.
commit c493e38a688700208c0ddffc44b7523fca30451b
Date: Mon Dec 12 18:12:35 2016 +0000
Use org.audacityteam.audacty
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Paul Licameli

2016-12-27 15:51:11 UTC

Permalink

I tried again, cleaning and completely rebuilding both debug and release,
and I still see the problem.

PRL

Post by Gale Andrews
I am not seeing that on macOS Sierra10.12.2 on a 1280*1024 monitor.
Release build of HEAD built yesterday.
Gale

Post by Paul Licameli
I am running MacOs 10.11.6.
If I build present head and generate sound, and Export Audio, then I get

Post by Paul Licameli
Save dialog that does not as previously have an upper pane allowing
selection of a destination folder, and if I select MP3 Files as file

type,

Post by Paul Licameli
then the options pane below is sized too narrow. The rightmost of the

radio

Post by Paul Licameli
buttons for Bit Rate Mode shows only a semicircle and has no caption.

The

Post by Paul Licameli
dialog cannot be resized.
commit c493e38a688700208c0ddffc44b7523fca30451b
Date: Mon Dec 12 18:12:35 2016 +0000
Use org.audacityteam.audacty
------------------------------------------------------------

------------------

Post by Paul Licameli
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Cliff Scott

2016-12-27 16:11:09 UTC

Permalink

Paul,

Could you post a screen shot of the dialog so I can see exactly what you are seeing? I got a small dialog like I suspect you are seeing, but clicking on the arrow to the right of the "save as " title expands the dialog to include the fuller view to choose the destination folder. If I don't expand it first and choose the file type mp3, as you say part of the options are covered because the dialog isn't wide enough. Expand it by clicking on the arrow beside the "save as" field and all is visible.

This will happen with all the older ones as well which is why I would like to see exactly what you are describing.

Cliff

I tried again, cleaning and completely rebuilding both debug and release, and I still see the problem.
PRL
I am not seeing that on macOS Sierra10.12.2 on a 1280*1024 monitor.
Release build of HEAD built yesterday.
Gale

Post by Paul Licameli
I am running MacOs 10.11.6.
If I build present head and generate sound, and Export Audio, then I get a
Save dialog that does not as previously have an upper pane allowing
selection of a destination folder, and if I select MP3 Files as file type,
then the options pane below is sized too narrow. The rightmost of the radio
buttons for Bit Rate Mode shows only a semicircle and has no caption. The
dialog cannot be resized.
commit c493e38a688700208c0ddffc44b7523fca30451b
Date: Mon Dec 12 18:12:35 2016 +0000
Use org.audacityteam.audacty
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot <http://sdm.link/slashdot>
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot <http://sdm.link/slashdot>
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Paul Licameli

2016-12-27 16:33:28 UTC

Permalink

Post by Cliff Scott
Paul,
Could you post a screen shot of the dialog so I can see exactly what you
are seeing? I got a small dialog like I suspect you are seeing, but
clicking on the arrow to the right of the "save as " title expands the
dialog to include the fuller view to choose the destination folder. If I
don't expand it first and choose the file type mp3, as you say part of the
options are covered because the dialog isn't wide enough. Expand it by
clicking on the arrow beside the "save as" field and all is visible.
This will happen with all the older ones as well which is why I would like
to see exactly what you are describing.

"Older ones" meaning older commits?

I see no arrow right of "Save As".

Maybe it is relevant, that my Xcode version is 6.4.

See attachment.

PRL

Post by Cliff Scott
Cliff
I tried again, cleaning and completely rebuilding both debug and release,
and I still see the problem.
PRL

Post by Gale Andrews
I am not seeing that on macOS Sierra10.12.2 on a 1280*1024 monitor.
Release build of HEAD built yesterday.
Gale

Post by Paul Licameli
I am running MacOs 10.11.6.
If I build present head and generate sound, and Export Audio, then I

get a

Post by Paul Licameli
Save dialog that does not as previously have an upper pane allowing
selection of a destination folder, and if I select MP3 Files as file

type,

Post by Paul Licameli
then the options pane below is sized too narrow. The rightmost of the

radio

Post by Paul Licameli
buttons for Bit Rate Mode shows only a semicircle and has no caption.

The

------------------

Post by Paul Licameli
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org <http://slashdot.org>!

http://sdm.link/slashdot

Post by Paul Licameli
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org <http://slashdot.org>!
http://sdm.link/slashdot_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

James Crook

2016-12-27 16:41:34 UTC

Permalink

Thanks Cliff.

That's what I see too. I don't think there's a problem.
I see same results on builds back to 3rd December, and also on reverting
just changes for that commit onto head.

Paul there is a downward pointing arrow in your screenshot. It's the
upside down circumflex thing to the right of the blue-focussed save as
box that has the word 'Untitled' in it.

--James.

Post by Cliff Scott
Paul,
Could you post a screen shot of the dialog so I can see exactly what you are seeing? I got a small dialog like I suspect you are seeing, but clicking on the arrow to the right of the "save as " title expands the dialog to include the fuller view to choose the destination folder. If I don't expand it first and choose the file type mp3, as you say part of the options are covered because the dialog isn't wide enough. Expand it by clicking on the arrow beside the "save as" field and all is visible.
This will happen with all the older ones as well which is why I would like to see exactly what you are describing.
Cliff

Post by Paul Licameli
I am running MacOs 10.11.6.
If I build present head and generate sound, and Export Audio, then I get a
Save dialog that does not as previously have an upper pane allowing
selection of a destination folder, and if I select MP3 Files as file type,
then the options pane below is sized too narrow. The rightmost of the radio
buttons for Bit Rate Mode shows only a semicircle and has no caption. The
dialog cannot be resized.
commit c493e38a688700208c0ddffc44b7523fca30451b
Date: Mon Dec 12 18:12:35 2016 +0000
Use org.audacityteam.audacty
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot <http://sdm.link/slashdot>
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>

Paul Licameli

2016-12-27 16:56:24 UTC

Permalink

I took Cliff too literally when he said "title." It's not in the title.

Is this an anticipated consequence of the commit?

I still don't like it -- I think it is a bit non-obvious how to widen the
dialog so that I see all the option controls. I try to drag the dialog
wider and I cannot.

PRL

Post by James Crook
Thanks Cliff.
That's what I see too. I don't think there's a problem.
I see same results on builds back to 3rd December, and also on reverting
just changes for that commit onto head.
Paul there is a downward pointing arrow in your screenshot. It's the
upside down circumflex thing to the right of the blue-focussed save as box
that has the word 'Untitled' in it.
--James.
Paul,
Could you post a screen shot of the dialog so I can see exactly what you are seeing? I got a small dialog like I suspect you are seeing, but clicking on the arrow to the right of the "save as " title expands the dialog to include the fuller view to choose the destination folder. If I don't expand it first and choose the file type mp3, as you say part of the options are covered because the dialog isn't wide enough. Expand it by clicking on the arrow beside the "save as" field and all is visible.
This will happen with all the older ones as well which is why I would like to see exactly what you are describing.
Cliff
I tried again, cleaning and completely rebuilding both debug and release, and I still see the problem.
PRL
I am not seeing that on macOS Sierra10.12.2 on a 1280*1024 monitor.
Release build of HEAD built yesterday.
Gale
I am running MacOs 10.11.6.
If I build present head and generate sound, and Export Audio, then I get a
Save dialog that does not as previously have an upper pane allowing
selection of a destination folder, and if I select MP3 Files as file type,
then the options pane below is sized too narrow. The rightmost of the radio
buttons for Bit Rate Mode shows only a semicircle and has no caption. The
dialog cannot be resized.
commit c493e38a688700208c0ddffc44b7523fca30451b
Date: Mon Dec 12 18:12:35 2016 +0000
Use org.audacityteam.audacty
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot <http://sdm.link/slashdot> <http://sdm.link/slashdot>
_______________________________________________
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot <http://sdm.link/slashdot> <http://sdm.link/slashdot>
_______________________________________________
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot_______________________________________________
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

James Crook

2016-12-27 17:05:52 UTC

Permalink

Post by Paul Licameli
I took Cliff too literally when he said "title." It's not in the title.
Is this an anticipated consequence of the commit?

It's not an anticipated, nor intended consequence of the commit, nor an
actual consequence of it.

Having seen the compact save as dialog, I did lots of variant builds,
including back to 3rd December, which is before the commit you refer
to. It happens with this commit too:

Commit hash: 493230e1410aa2e5a8f465a9c170780a40115102
Update Basque Translation by Xabier Aramendi

So landing up on my commit is some artifact of the bisect process. It
isn't caused by those two files being changed, and does not go away by
reverting those two files.

--James.

Post by Paul Licameli
I still don't like it -- I think it is a bit non-obvious how to widen the
dialog so that I see all the option controls. I try to drag the dialog
wider and I cannot.
PRL

Paul Licameli

2016-12-27 17:16:02 UTC

Permalink

Post by James Crook

Post by Paul Licameli
I took Cliff too literally when he said "title." It's not in the title.
Is this an anticipated consequence of the commit?

It's not an anticipated, nor intended consequence of the commit, nor an
actual consequence of it.
Having seen the compact save as dialog, I did lots of variant builds,
including back to 3rd December, which is before the commit you refer
Commit hash: 493230e1410aa2e5a8f465a9c170780a40115102
Update Basque Translation by Xabier Aramendi
So landing up on my commit is some artifact of the bisect process. It
isn't caused by those two files being changed, and does not go away by
reverting those two files.
--James.

I observe different effects on my system. The problem (if problem we think
it) reliably happens at c493e38a688700208c0ddffc44b7523fca30451b and not
before that. And not at 493230e1410aa2e5a8f465a9c170780a40115102.

PRL

Post by James Crook

Post by Paul Licameli
I still don't like it -- I think it is a bit non-obvious how to widen the
dialog so that I see all the option controls. I try to drag the dialog
wider and I cannot.
PRL

box