[Audacity-devel] Commit 79c5834a2483c1e54009395a940598892146a67d breaks the Mac Build

[Paul Licameli]

That is all.
PRL

[James Crook]

Paul,

That's this fix for http://bugzilla.audacityteam.org/show_bug.cgi?id=1506

#if defined __GNUC__ && ( __GNUC__ < 4 || (__GNUC__ == 4 &&
__GNUC_MINOR__ < 9))
#error insufficient compiler
#endif

And we determined that if using GCC, 4.8.2 was too low for Linux, even
though compiling the new idioms.
http://bugzilla.audacityteam.org/show_bug.cgi?id=1397


We could change the test to:

#if !defined __APPLE__ && defined __GNUC__ && ( __GNUC__ < 4 ||
(__GNUC__ == 4 && __GNUC_MINOR__ < 9))
#error insufficient compiler
#endif

Just to allow Mac to compile as before. However I'm concerned that we
might be needing to build on Mac with 4.9 or greater too, not just on
Linux. So I did not check in the above 'fix', which might be like
cutting the oil indicator low wire to 'fix' the oil low problem.

Paul - What version of GCC are you using on Mac?


--James.

Post by Paul Licameli
That is all.
PRL

[Gale Andrews]

Post by James Crook
Paul,
That's this fix for http://bugzilla.audacityteam.org/show_bug.cgi?id=1506
#if defined __GNUC__ && ( __GNUC__ < 4 || (__GNUC__ == 4 &&
__GNUC_MINOR__ < 9))
#error insufficient compiler
#endif
And we determined that if using GCC, 4.8.2 was too low for Linux, even
though compiling the new idioms.
http://bugzilla.audacityteam.org/show_bug.cgi?id=1397
#if !defined __APPLE__ && defined __GNUC__ && ( __GNUC__ < 4 ||
(__GNUC__ == 4 && __GNUC_MINOR__ < 9))
#error insufficient compiler
#endif
Just to allow Mac to compile as before.

Yes we could (I confirm that does compile for me) but this is the wrong place
for the fix anyway, still leaving a P2 that we make people start
compiling before
they find the problem.

Post by James Crook
However I'm concerned that we
might be needing to build on Mac with 4.9 or greater too, not just on
Linux. So I did not check in the above 'fix', which might be like
cutting the oil indicator low wire to 'fix' the oil low problem.
Paul - What version of GCC are you using on Mac?

I see 4.2.1 on Sierra but I don't know how meaningful that is - see
http://stackoverflow.com/questions/20410587/how-to-find-gcc-version-on-mac

http://stackoverflow.com/questions/20171095/why-cant-i-check-my-version-of-gcc-compiler-on-os-x.

My output:

Gales-Mac-mini:~ gale$ gcc -v
Configured with:
--prefix=/Applications/Xcode.app/Contents/Developer/usr
--with-gxx-include-dir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/include/c++/4.2.1
Apple LLVM version 7.0.0 (clang-700.1.76)
Target: x86_64-apple-darwin16.0.0
Thread model: posix

Even on older OS X, according to one of the above links, the mac gcc
was an extended version so not the same as the GNU gcc.

I'd guess this isn't a problem unless a Mac developer employs hackage
to use GNU gcc?


Gale

Post by James Crook
--James.

Post by Paul Licameli
That is all.
PRL

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel