[Audacity-devel] [Audacity-quality] More about one-pixel changes from 2.1.3 in drawing the buttons on TCP

[James Crook]

Now comparing 2.2.0 with 2.1.3, these are drawing changes in the buttons
that I notice, and I ask whether all were intended and are agreed on as
In 2.1.3 the close, menu, and Mute buttons invade the border at top and
left. I'm not sure that's bad: it contributes to the illusion that the
buttons are slightly raised. But 2.2.0 no longer does this.
In 2.2.0 the Minimize button invades the border below, but not so in 2.1.3.
In 2.2.0 the Menu button extends a bit more rightward than Mute does, and
invades the separator between the track control panel and the vertical
ruler.
In 2.2.0 the Close, Mute, Solo, Menu, and Minimize buttons are all slightly
taller.
PRL

At one time I put a fair bit of time into making the buttons AND the TCP
AND the vertical ruler have nicely lined up '3D bevel effect'. At some
point someone else decided to remove the 3D effect on the TCP. I think
it was when the collapse/expand button came in.

I don't think we have to keep the exact same look as we have had in the
past. We can't anyway as the decoration provided by windows is changing
too.

Bear in mind that the sizing has to work in other themes besides
Classic. For Bevels buttons should go right out to the edge, but for
other shapes there probably should be a gap/border.

There is currently a 1 pixel inconsistency between the 'name' button
right edge and the solo button right edge. That probably should be
fixed, and both made to be like the 'name' button right edge.

--James.

[Paul Licameli]

Post by James Crook

Now comparing 2.2.0 with 2.1.3, these are drawing changes in the buttons
that I notice, and I ask whether all were intended and are agreed on as
In 2.1.3 the close, menu, and Mute buttons invade the border at top and
left. I'm not sure that's bad: it contributes to the illusion that the
buttons are slightly raised. But 2.2.0 no longer does this.
In 2.2.0 the Minimize button invades the border below, but not so in 2.1.3.
In 2.2.0 the Menu button extends a bit more rightward than Mute does, and
invades the separator between the track control panel and the vertical
ruler.
In 2.2.0 the Close, Mute, Solo, Menu, and Minimize buttons are all slightly
taller.
PRL

At one time I put a fair bit of time into making the buttons AND the TCP
AND the vertical ruler have nicely lined up '3D bevel effect'. At some
point someone else decided to remove the 3D effect on the TCP. I think it
was when the collapse/expand button came in.
I don't think we have to keep the exact same look as we have had in the
past. We can't anyway as the decoration provided by windows is changing
too.
Bear in mind that the sizing has to work in other themes besides Classic.
For Bevels buttons should go right out to the edge, but for other shapes
there probably should be a gap/border.
There is currently a 1 pixel inconsistency between the 'name' button right
edge and the solo button right edge. That probably should be fixed, and
both made to be like the 'name' button right edge.
--James.

Yes, I wrote Mute when I meant Solo, but I thought it was the Menu button
that was wider than intended, not the Solo that was too narrow.

I add one more anomaly to my list:

If you compile with EXPERIMENTAL_DA, or of you choose no solo button in
Tracks behavior preferences, then the Mute button is not positioned
symmetrically between the boundaries of the track control panel, though the
code I read suggests to me that this was the intent, not successfully
implemented.

James, please review my recent commit 191eeaf. See commit comments and
code comments. I made no display changes, but rewrote things in equivalent
form. Please modify as needed so that the code truly reflects your
intentions for rearranging buttons.

There seemed to be much confusion in TrackPanel code as to whether the
rectangle objects passed around in it did or did not include the "framing"
lines around the three informative areas (track controls, vertical ruler,
and the track proper). I am trying to rewrite things so that all such
framing, on all sides, is now excluded. I think some mistakes happened on
the assumption that they were excluded, when in fact they had not been.

PRL

Post by James Crook
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel