Discussion:
[Audacity-devel] Can't scroll beyond zero after TracksBehaviorsPrefs.cpp was split out
Paul Licameli
2017-04-29 11:21:24 UTC
Permalink
I don't think this was Steve's intention.

Experimental.h must be included in the new .cpp file or else the preference
check box is no longer displayed. But the file compiled without the
inclusion.

PRL
Peter Sampson
2017-04-29 11:35:23 UTC
Permalink
I'm still seeing "Enable scrolling left of zero" in the new Tracks
Behaviors prefs pane.

Testing on W10 audacity-win-r51517fa-2.2.0-alpha-27-apr-17

Peter
Post by Paul Licameli
I don't think this was Steve's intention.
Experimental.h must be included in the new .cpp file or else the
preference check box is no longer displayed. But the file compiled without
the inclusion.
PRL
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
James Crook
2017-04-29 11:45:54 UTC
Permalink
Fixed in
https://github.com/audacity/audacity/commit/615a5058a7a3dde814627f0ce0143be1304c9a25

Track.h already includes Experiemental.h, and Track.h is included in
nearly all .cpp files in Windows builds because of force-including
AudacityHeaders.h, so you wouldn't see the problem in Windows builds.

--James.
Post by Peter Sampson
I'm still seeing "Enable scrolling left of zero" in the new Tracks
Behaviors prefs pane.
Testing on W10 audacity-win-r51517fa-2.2.0-alpha-27-apr-17
Peter
Post by Paul Licameli
I don't think this was Steve's intention.
Experimental.h must be included in the new .cpp file or else the
preference check box is no longer displayed. But the file compiled without
the inclusion.
PRL
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Steve the Fiddle
2017-04-29 12:40:49 UTC
Permalink
Good catch Paul. No that wasn't intended.
Thanks for the quick fix James.

Steve
Post by James Crook
Fixed in
https://github.com/audacity/audacity/commit/615a5058a7a3dde814627f0ce0143be1304c9a25
Track.h already includes Experiemental.h, and Track.h is included in nearly
all .cpp files in Windows builds because of force-including
AudacityHeaders.h, so you wouldn't see the problem in Windows builds.
--James.
I'm still seeing "Enable scrolling left of zero" in the new Tracks
Behaviors prefs pane.
Testing on W10 audacity-win-r51517fa-2.2.0-alpha-27-apr-17
Peter
I don't think this was Steve's intention.
Experimental.h must be included in the new .cpp file or else the
preference check box is no longer displayed. But the file compiled without
the inclusion.
PRL
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Loading...