[Audacity-devel] Changed History dialog

I've added a placeholder P1 in the Manual for that Paul.

Peter

Post by Paul Licameli
I have implemented the idea of a new button in the History dialog that
clears the clipboard, and also a text box displaying the clipboard disk
space usage.
It is at commit 93c0b5a92da0ac4b06740b40735cc93e23a574a1
PRL
------------------------------------------------------------
------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Paul Licameli

2016-11-07 18:52:31 UTC

Let the minor wrangling over new names of buttons and texts proceed.

PRL

On Mon, Nov 7, 2016 at 11:35 AM, Peter Sampson <

Post by Peter Sampson
I've added a placeholder P1 in the Manual for that Paul.
Peter

------------------------------------------------------------
------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Peter Sampson

2016-11-07 18:58:06 UTC

Post by Paul Licameli
Let the minor wrangling over new names of buttons and texts proceed.

That's why it's only a "placeholder P1" ;-))

Peter

Post by Paul Licameli
Let the minor wrangling over new names of buttons and texts proceed.
PRL
On Mon, Nov 7, 2016 at 11:35 AM, Peter Sampson <

Post by Peter Sampson
I've added a placeholder P1 in the Manual for that Paul.
Peter

Peter Sampson

2016-11-08 16:29:13 UTC

Hi Paul,

I just tested this on the latest Mac nightly on Sierra.

It seems to work as mostly I'm sure you intended it - but see below

My big question though is why have you chosen to add the clipboard
contents discard on the History dialog - I suspect you'll say that they
are both indicators of space occupancy.

But I would have thought that clearing the clipboard, if necessary at all,
would be better done fom a new command in the Edit Menu (where Copy
and Paste, the commands that populate the clipboard live).

BTW, I note the the Clipboard size indicator does not update immediately
in a timely fashion when the contents of the clipboard change.

1) Generate tone 30 seconds
2) Select All
3) Copy button
4) => no change to Clipboard Space at 0.0
5) Skip to end - no change from 0.0
6) Cmd+V to paste
7) now the Cipboard space shows 5.1 MB

8) Select 1 second
9) click Copy button
10) Clipboard space still shows 5.1 MB
11) Skip to end - no change from 5.1
12) Cmd+V to paste
13) now the Cipboard space shows 175.3 KB

Surely the Clipboard space should have updated at steps 3 & 9
when the Paste is invoked and the contents of the clipboard change.

Cheers,
Peter.

On Mon, Nov 7, 2016 at 6:58 PM, Peter Sampson <

Post by Paul Licameli
Let the minor wrangling over new names of buttons and texts proceed.

That's why it's only a "placeholder P1" ;-))
Peter

Post by Paul Licameli
Let the minor wrangling over new names of buttons and texts proceed.
PRL
On Mon, Nov 7, 2016 at 11:35 AM, Peter Sampson <

Post by Peter Sampson
I've added a placeholder P1 in the Manual for that Paul.
Peter

Paul Licameli

2016-11-08 16:34:59 UTC

On Tue, Nov 8, 2016 at 11:29 AM, Peter Sampson <

Post by Peter Sampson
Hi Paul,
I just tested this on the latest Mac nightly on Sierra.
It seems to work as mostly I'm sure you intended it - but see below
My big question though is why have you chosen to add the clipboard
contents discard on the History dialog - I suspect you'll say that they
are both indicators of space occupancy.
But I would have thought that clearing the clipboard, if necessary at all,
would be better done fom a new command in the Edit Menu (where Copy
and Paste, the commands that populate the clipboard live).

Peter, I thought that the user is likely to Discard only when directed to
do so by the new error message I have not yet committed, in case of
exhaustion of space during recording.

I thought it would be more convenient to keep these two space-recovering
buttons close together.

I think Gale agrees.

Post by Peter Sampson
BTW, I note the the Clipboard size indicator does not update immediately
in a timely fashion when the contents of the clipboard change.
1) Generate tone 30 seconds
2) Select All
3) Copy button
4) => no change to Clipboard Space at 0.0
5) Skip to end - no change from 0.0
6) Cmd+V to paste
7) now the Cipboard space shows 5.1 MB
8) Select 1 second
9) click Copy button
10) Clipboard space still shows 5.1 MB
11) Skip to end - no change from 5.1
12) Cmd+V to paste
13) now the Cipboard space shows 175.3 KB
Surely the Clipboard space should have updated at steps 3 & 9
when the Paste is invoked and the contents of the clipboard change.
Cheers,
Peter.

That is a bug. Let's track it.

Post by Paul Licameli
Let the minor wrangling over new names of buttons and texts proceed.

That's why it's only a "placeholder P1" ;-))
Peter

Post by Paul Licameli
Let the minor wrangling over new names of buttons and texts proceed.
PRL
On Mon, Nov 7, 2016 at 11:35 AM, Peter Sampson <

Post by Peter Sampson
I've added a placeholder P1 in the Manual for that Paul.
Peter

Peter Sampson

2016-11-08 16:42:30 UTC

Added to Bugzilla as P4 #1544:
http://bugzilla.audacityteam.org/show_bug.cgi?id=1544

Peter.

Post by Paul Licameli
On Tue, Nov 8, 2016 at 11:29 AM, Peter Sampson <

Peter, I thought that the user is likely to Discard only when directed to
do so by the new error message I have not yet committed, in case of
exhaustion of space during recording.
I thought it would be more convenient to keep these two space-recovering
buttons close together.
I think Gale agrees.

That is a bug. Let's track it.

Post by Peter Sampson
On Mon, Nov 7, 2016 at 6:58 PM, Peter Sampson <

Post by Paul Licameli
Let the minor wrangling over new names of buttons and texts proceed.

That's why it's only a "placeholder P1" ;-))
Peter

Post by Paul Licameli
Let the minor wrangling over new names of buttons and texts proceed.
PRL
On Mon, Nov 7, 2016 at 11:35 AM, Peter Sampson <

Post by Peter Sampson
I've added a placeholder P1 in the Manual for that Paul.
Peter

Post by Paul Licameli
I have implemented the idea of a new button in the History dialog
that clears the clipboard, and also a text box displaying the clipboard
disk space usage.
It is at commit 93c0b5a92da0ac4b06740b40735cc93e23a574a1
PRL
------------------------------------------------------------
------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Steve the Fiddle

2016-11-08 18:40:56 UTC

On 8 November 2016 at 16:42, Peter Sampson

Post by Peter Sampson
http://bugzilla.audacityteam.org/show_bug.cgi?id=1544
Peter.

Post by Paul Licameli
On Tue, Nov 8, 2016 at 11:29 AM, Peter Sampson

If it were an item in the Edit menu, then some users would probably
expect that it can be "undone" (like all other Edit commands), though
of course it can't. In a worst case scenario, this could cause a (very
naive and confused) user to lose data.

Post by Paul Licameli
Peter, I thought that the user is likely to Discard only when directed to
do so by the new error message I have not yet committed, in case of
exhaustion of space during recording.
I thought it would be more convenient to keep these two space-recovering
buttons close together.

Perhaps the relevance would be clearer if we change the dialog text from:
"Manage History"
to
"Manage Disk Use"

(or maybe not, but that association makes sense to me ;-)

Steve

Post by Paul Licameli
I think Gale agrees.

That is a bug. Let's track it.

Post by Peter Sampson
On Mon, Nov 7, 2016 at 6:58 PM, Peter Sampson

Post by Paul Licameli
Let the minor wrangling over new names of buttons and texts proceed.

That's why it's only a "placeholder P1" ;-))
Peter

Post by Paul Licameli
Let the minor wrangling over new names of buttons and texts proceed.
PRL
On Mon, Nov 7, 2016 at 11:35 AM, Peter Sampson

Post by Peter Sampson
I've added a placeholder P1 in the Manual for that Paul.
Peter
On Mon, Nov 7, 2016 at 4:27 PM, Paul Licameli

Paul Licameli

2016-11-08 18:46:06 UTC

Post by Steve the Fiddle
On 8 November 2016 at 16:42, Peter Sampson

Post by Peter Sampson
http://bugzilla.audacityteam.org/show_bug.cgi?id=1544
Peter.

Post by Paul Licameli
On Tue, Nov 8, 2016 at 11:29 AM, Peter Sampson

Post by Paul Licameli
Peter, I thought that the user is likely to Discard only when directed

Post by Paul Licameli
do so by the new error message I have not yet committed, in case of
exhaustion of space during recording.
I thought it would be more convenient to keep these two space-recovering
buttons close together.

"Manage History"
to
"Manage Disk Use"
(or maybe not, but that association makes sense to me ;-)

But of course the dialog does have other uses than managing disk use, such
as undoing many steps at once.

PRL

Post by Steve the Fiddle
Steve

Post by Paul Licameli
I think Gale agrees.

Post by Peter Sampson
BTW, I note the the Clipboard size indicator does not update

immediately

Post by Peter Sampson
in a timely fashion when the contents of the clipboard change.
1) Generate tone 30 seconds
2) Select All
3) Copy button
4) => no change to Clipboard Space at 0.0
5) Skip to end - no change from 0.0
6) Cmd+V to paste
7) now the Cipboard space shows 5.1 MB
8) Select 1 second
9) click Copy button
10) Clipboard space still shows 5.1 MB
11) Skip to end - no change from 5.1
12) Cmd+V to paste
13) now the Cipboard space shows 175.3 KB
Surely the Clipboard space should have updated at steps 3 & 9
when the Paste is invoked and the contents of the clipboard change.
Cheers,
Peter.

That is a bug. Let's track it.

Post by Peter Sampson
On Mon, Nov 7, 2016 at 6:58 PM, Peter Sampson

Post by Paul Licameli
Let the minor wrangling over new names of buttons and texts proceed.

That's why it's only a "placeholder P1" ;-))
Peter
On Mon, Nov 7, 2016 at 6:52 PM, Paul Licameli <

Post by Paul Licameli
Let the minor wrangling over new names of buttons and texts proceed.
PRL
On Mon, Nov 7, 2016 at 11:35 AM, Peter Sampson

Post by Peter Sampson
I've added a placeholder P1 in the Manual for that Paul.
Peter
On Mon, Nov 7, 2016 at 4:27 PM, Paul Licameli

Post by Paul Licameli
I have implemented the idea of a new button in the History dialog
that clears the clipboard, and also a text box displaying the

clipboard disk

Post by Paul Licameli
space usage.
It is at commit 93c0b5a92da0ac4b06740b40735cc93e23a574a1
PRL

Gale Andrews

2016-11-09 02:18:37 UTC

Given you can't undo discarding the clipboard, perhaps call the
History window title bar just "History" - it then matches with the
menu item, which we also like to do.

Gale

Post by Steve the Fiddle
On 8 November 2016 at 16:42, Peter Sampson

Post by Peter Sampson
http://bugzilla.audacityteam.org/show_bug.cgi?id=1544
Peter.

Post by Paul Licameli
On Tue, Nov 8, 2016 at 11:29 AM, Peter Sampson

"Manage History"
to
"Manage Disk Use"
(or maybe not, but that association makes sense to me ;-)

But of course the dialog does have other uses than managing disk use, such
as undoing many steps at once.
PRL

Post by Steve the Fiddle
Steve

Post by Paul Licameli
I think Gale agrees.

That is a bug. Let's track it.

Post by Peter Sampson
On Mon, Nov 7, 2016 at 6:58 PM, Peter Sampson

Post by Paul Licameli
Let the minor wrangling over new names of buttons and texts proceed.

That's why it's only a "placeholder P1" ;-))
Peter
On Mon, Nov 7, 2016 at 6:52 PM, Paul Licameli

Post by Paul Licameli
Let the minor wrangling over new names of buttons and texts proceed.
PRL
On Mon, Nov 7, 2016 at 11:35 AM, Peter Sampson

Post by Peter Sampson
I've added a placeholder P1 in the Manual for that Paul.
Peter
On Mon, Nov 7, 2016 at 4:27 PM, Paul Licameli

------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Peter Sampson

2016-11-09 10:12:59 UTC

Post by Gale Andrews
Given you can't undo discarding the clipboard, perhaps call the
History window title bar just "History" - it then matches with the
menu item, which we also like to do.

+1

Good call Gale.

Peter.

Paul Licameli

2016-11-09 12:03:05 UTC

I have fixed it.

Notice too what was right from the start: If you use the new Discard
button, then the Paste button in the Edit toolbar disables.

PRL

On Tue, Nov 8, 2016 at 11:42 AM, Peter Sampson <

Post by Peter Sampson
http://bugzilla.audacityteam.org/show_bug.cgi?id=1544
Peter.

Post by Paul Licameli
On Tue, Nov 8, 2016 at 11:29 AM, Peter Sampson <

Peter, I thought that the user is likely to Discard only when directed to
do so by the new error message I have not yet committed, in case of
exhaustion of space during recording.
I thought it would be more convenient to keep these two space-recovering
buttons close together.
I think Gale agrees.

That is a bug. Let's track it.

Post by Peter Sampson
On Mon, Nov 7, 2016 at 6:58 PM, Peter Sampson <

Post by Paul Licameli
Let the minor wrangling over new names of buttons and texts proceed.

That's why it's only a "placeholder P1" ;-))
Peter

Post by Paul Licameli
Let the minor wrangling over new names of buttons and texts proceed.
PRL
On Mon, Nov 7, 2016 at 11:35 AM, Peter Sampson <

Post by Peter Sampson
I've added a placeholder P1 in the Manual for that Paul.
Peter
On Mon, Nov 7, 2016 at 4:27 PM, Paul Licameli <

Post by Paul Licameli
I have implemented the idea of a new button in the History dialog
that clears the clipboard, and also a text box displaying the clipboard
disk space usage.
It is at commit 93c0b5a92da0ac4b06740b40735cc93e23a574a1
PRL
------------------------------------------------------------
------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Peter Sampson

2016-11-09 12:11:31 UTC

Post by Paul Licameli
Notice too what was right from the start: If you use the new Discard

button,

Post by Paul Licameli
then the Paste button in the Edit toolbar disables.

Yes I spotted that was ok yesterday - that's why I didn't comment *(no bug,
no issue)* ;-))

I'll retest when the new builds become available.

Peter.

Peter Sampson

2016-11-09 13:11:41 UTC

Tested on macOS Sierra 53a5c93

tested for Cut, Split Cut, Copy, and also for the same commands in the
Labeled Audio sub-menu of Edit. Tested with buttons and shortcuts too.

In all cases the History window clipboard data is properly updated
dynamically as it occurs.

1) I note that you did not do as GAle suggested and rename the History
window to just "History" (rather than "Undo History") so that we get
consistency bewtween the menu command and the window name.

2) Do we need the extra labelling of the pane as "Manage History"

I'll test on Windows when the next nightly build arrives.

Peter.

Gale Andrews

2016-11-09 18:25:30 UTC

On 9 November 2016 at 13:11, Peter Sampson

Post by Peter Sampson
Tested on macOS Sierra 53a5c93
tested for Cut, Split Cut, Copy, and also for the same commands in the
Labeled Audio sub-menu of Edit. Tested with buttons and shortcuts too.
In all cases the History window clipboard data is properly updated
dynamically as it occurs.
1) I note that you did not do as GAle suggested and rename the History
window to just "History" (rather than "Undo History") so that we get
consistency bewtween the menu command and the window name.

I can do that if no-one strongly demurs.

Post by Peter Sampson
2) Do we need the extra labelling of the pane as "Manage History"

I suppose that is because we made a static box (if I name it correctly)
which should have a title. We could do without the box as in Run
Benchmark (+1) or have a separate box for the Clipboard. If it needs
a lot of discussion, I suggest putting it on -quality.

Gale

Post by Peter Sampson
I'll test on Windows when the next nightly build arrives.
Peter.
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Paul Licameli

2016-11-09 18:49:02 UTC