Discussion:
[Audacity-devel] Latest Windows Nightly
Steve the Fiddle
2016-11-22 12:53:19 UTC
Permalink
The Windows Nightly for 22nd Nov (Zip) does not contain the new Sample Data
Import plug-in. Why is that and what needs to be done to correct it?

Steve
Gale Andrews
2016-11-22 14:45:17 UTC
Permalink
If you don't add your new plugin to

* win/Projects/Audacity/Audacity.vcxproj
* win/Projects/Audacity/Audacity.vcxproj.filters

then fairly obviously it won't get into the Windows build. I can add
it for Windows shortly if no-one else beats me to it.

The plugin needs to be added to the Mac project too using Xcode.

According to its documentation, the plugin appears to be a crash risk if user
tries to import a file it does not support. Was its inclusion agreed somewhere?



Gale
Post by Steve the Fiddle
The Windows Nightly for 22nd Nov (Zip) does not contain the new Sample Data
Import plug-in. Why is that and what needs to be done to correct it?
Steve
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Gale Andrews
2016-11-22 14:59:32 UTC
Permalink
Also you didn't make the relevant Makefile changes, so I don't have
the plugin in my latest build on Linux.


Gale
Post by Gale Andrews
If you don't add your new plugin to
* win/Projects/Audacity/Audacity.vcxproj
* win/Projects/Audacity/Audacity.vcxproj.filters
then fairly obviously it won't get into the Windows build. I can add
it for Windows shortly if no-one else beats me to it.
The plugin needs to be added to the Mac project too using Xcode.
According to its documentation, the plugin appears to be a crash risk if user
tries to import a file it does not support. Was its inclusion agreed somewhere?
Gale
Post by Steve the Fiddle
The Windows Nightly for 22nd Nov (Zip) does not contain the new Sample Data
Import plug-in. Why is that and what needs to be done to correct it?
Steve
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Steve the Fiddle
2016-11-22 15:39:02 UTC
Permalink
Post by Gale Andrews
If you don't add your new plugin to
* win/Projects/Audacity/Audacity.vcxproj
* win/Projects/Audacity/Audacity.vcxproj.filters
then fairly obviously it won't get into the Windows build. I can add
it for Windows shortly if no-one else beats me to it.
Rather harsh Gale. It obviously wasn't obvious to me, which is why I asked.
Post by Gale Andrews
The plugin needs to be added to the Mac project too using Xcode.
According to its documentation, the plugin appears to be a crash risk if user
tries to import a file it does not support. Was its inclusion agreed somewhere?
Yes, about 4 years ago when I wrote Sample Data Export. It's been on my
ToDo list since then. Iirc you were, at the time, quite keen on having the
ability to import as well as export sample data.

The risk of crashing is actually quite low. The effect is a lot less
"risky" than the Nyquist Prompt effect, but there is probably greater
temptation for users, so better to overstate the risk with a prominent
warning. This is also why the effect will only accept files that have a
.txt file extension. In most cases, invalid data will simply produce an
error.

Steve
Post by Gale Andrews
Gale
Post by Steve the Fiddle
The Windows Nightly for 22nd Nov (Zip) does not contain the new Sample
Data
Post by Steve the Fiddle
Import plug-in. Why is that and what needs to be done to correct it?
Steve
------------------------------------------------------------
------------------
Post by Steve the Fiddle
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
James Crook
2016-11-22 16:46:31 UTC
Permalink
Post by Gale Andrews
Was its inclusion agreed somewhere?
Well, there is doer decides - but it looks to me as if this is an
attempt to add this to the release after we are frozen, as it is not
currently in linux, mac or windows project at the moment.

So at the moment RM is saying no to inclusion. It's missed the boat for
2.1.3. Yes the boat did leave rather suddenly, but the boat was very
long overdue setting sail. Steve, if you feel that is a bad decision
from the point of view of users, talk to me off list and cc Gale as
inclusion/non-inclusion is both a release and quality issue - and Gale
is right to query whether it was agreed for 2.1.3.

--James.
Post by Gale Andrews
Post by Gale Andrews
If you don't add your new plugin to
* win/Projects/Audacity/Audacity.vcxproj
* win/Projects/Audacity/Audacity.vcxproj.filters
then fairly obviously it won't get into the Windows build. I can add
it for Windows shortly if no-one else beats me to it.
Rather harsh Gale. It obviously wasn't obvious to me, which is why I asked.
Post by Gale Andrews
The plugin needs to be added to the Mac project too using Xcode.
According to its documentation, the plugin appears to be a crash risk if user
tries to import a file it does not support. Was its inclusion agreed somewhere?
Yes, about 4 years ago when I wrote Sample Data Export. It's been on my
ToDo list since then. Iirc you were, at the time, quite keen on having the
ability to import as well as export sample data.
The risk of crashing is actually quite low. The effect is a lot less
"risky" than the Nyquist Prompt effect, but there is probably greater
temptation for users, so better to overstate the risk with a prominent
warning. This is also why the effect will only accept files that have a
.txt file extension. In most cases, invalid data will simply produce an
error.
Steve
------------------------------------------------------------------------------
Steve the Fiddle
2016-11-23 09:48:29 UTC
Permalink
Post by James Crook
Post by Gale Andrews
Was its inclusion agreed somewhere?
Well, there is doer decides - but it looks to me as if this is an
attempt to add this to the release after we are frozen, as it is not
currently in linux, mac or windows project at the moment.
I'd like it to be on record that the plug-in was committed,
*and_documented_in_the_manual* within 24 hours of James writing (in a
conversation with Paul) "so current plan is to go into freeze tomorrow".
The plug-in has been in the GitHub Zip file, and the Mac nightly since that
time. I had forgotten the (undocumented) "packaging" steps, and did not
notice the error until the next Windows "nightly" came out on 22nd November.

Steve
Post by James Crook
So at the moment RM is saying no to inclusion. It's missed the boat for
2.1.3. Yes the boat did leave rather suddenly, but the boat was very
long overdue setting sail. Steve, if you feel that is a bad decision
from the point of view of users, talk to me off list and cc Gale as
inclusion/non-inclusion is both a release and quality issue - and Gale
is right to query whether it was agreed for 2.1.3.
--James.
Post by Gale Andrews
Post by Gale Andrews
If you don't add your new plugin to
* win/Projects/Audacity/Audacity.vcxproj
* win/Projects/Audacity/Audacity.vcxproj.filters
then fairly obviously it won't get into the Windows build. I can add
it for Windows shortly if no-one else beats me to it.
Rather harsh Gale. It obviously wasn't obvious to me, which is why I
asked.
Post by Gale Andrews
Post by Gale Andrews
The plugin needs to be added to the Mac project too using Xcode.
According to its documentation, the plugin appears to be a crash risk if user
tries to import a file it does not support. Was its inclusion agreed somewhere?
Yes, about 4 years ago when I wrote Sample Data Export. It's been on my
ToDo list since then. Iirc you were, at the time, quite keen on having
the
Post by Gale Andrews
ability to import as well as export sample data.
The risk of crashing is actually quite low. The effect is a lot less
"risky" than the Nyquist Prompt effect, but there is probably greater
temptation for users, so better to overstate the risk with a prominent
warning. This is also why the effect will only accept files that have a
.txt file extension. In most cases, invalid data will simply produce an
error.
Steve
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
James Crook
2016-11-23 11:39:37 UTC
Permalink
Steve,

If you would like to delay the release to give time to fix the crash
bug, do the packaging steps and have Gale do preliminary test of the
Sample Data Import plug in, then I'm OK to give an extra 3 days. That
would also give the translators 3 extra days, which I am sure they would
welcome.

I think 3 days warning WOULD have been reasonable warning for freeze, so
I am not OK to give more than 3 days for this. From my perspective,
from what I am hearing so far, the plug-in isn't actually ready yet and
should anyway have been held over to 2.1.4. I'd happily be proved wrong
on that, and it would give another feature for the announce message.

If it is just that the wording in the documentation and the big red
alert there that is massively over cautious, then a change to the
documentation (and packaging) alone might be enough.

--James.
Post by Steve the Fiddle
Post by James Crook
Post by Gale Andrews
Was its inclusion agreed somewhere?
Well, there is doer decides - but it looks to me as if this is an
attempt to add this to the release after we are frozen, as it is not
currently in linux, mac or windows project at the moment.
I'd like it to be on record that the plug-in was committed,
*and_documented_in_the_manual* within 24 hours of James writing (in a
conversation with Paul) "so current plan is to go into freeze tomorrow".
The plug-in has been in the GitHub Zip file, and the Mac nightly since that
time. I had forgotten the (undocumented) "packaging" steps, and did not
notice the error until the next Windows "nightly" came out on 22nd November.
Steve
------------------------------------------------------------------------------
Peter Sampson
2016-11-23 11:43:44 UTC
Permalink
The three day extension will give us time to get David's recent
update to fix the display behaviour of ALT+RIGHT/LEFT to
make it consistent with our pre-existing tabbing behaviour with
labels.

Peter
Post by James Crook
Steve,
If you would like to delay the release to give time to fix the crash
bug, do the packaging steps and have Gale do preliminary test of the
Sample Data Import plug in, then I'm OK to give an extra 3 days. That
would also give the translators 3 extra days, which I am sure they would
welcome.
I think 3 days warning WOULD have been reasonable warning for freeze, so
I am not OK to give more than 3 days for this. From my perspective,
from what I am hearing so far, the plug-in isn't actually ready yet and
should anyway have been held over to 2.1.4. I'd happily be proved wrong
on that, and it would give another feature for the announce message.
If it is just that the wording in the documentation and the big red
alert there that is massively over cautious, then a change to the
documentation (and packaging) alone might be enough.
--James.
Post by Steve the Fiddle
Post by James Crook
Post by Gale Andrews
Was its inclusion agreed somewhere?
Well, there is doer decides - but it looks to me as if this is an
attempt to add this to the release after we are frozen, as it is not
currently in linux, mac or windows project at the moment.
I'd like it to be on record that the plug-in was committed,
*and_documented_in_the_manual* within 24 hours of James writing (in a
conversation with Paul) "so current plan is to go into freeze tomorrow".
The plug-in has been in the GitHub Zip file, and the Mac nightly since
that
Post by Steve the Fiddle
time. I had forgotten the (undocumented) "packaging" steps, and did not
notice the error until the next Windows "nightly" came out on 22nd
November.
Post by Steve the Fiddle
Steve
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
James Crook
2016-11-23 12:26:33 UTC
Permalink
Post by Peter Sampson
The three day extension will give us time to get David's recent
update to fix the display behaviour of ALT+RIGHT/LEFT to
make it consistent with our pre-existing tabbing behaviour with
labels.
That doesn't need an extension. David shared a branch with the fix in 2
hrs ago. It looks fine, and I have checked it in to GitHub.
--James.



------------------------------------------------------------------------------
Peter Sampson
2016-11-23 12:34:18 UTC
Permalink
Post by James Crook
Post by Peter Sampson
The three day extension will give us time to get David's recent
update to fix the display behaviour of ALT+RIGHT/LEFT to
make it consistent with our pre-existing tabbing behaviour with
labels.
That doesn't need an extension. David shared a branch with the fix in 2
hrs ago. It looks fine, and I have checked it in to GitHub.
Wahay :-))

Peter
Post by James Crook
--James.
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
James Crook
2016-11-23 14:37:24 UTC
Permalink
Following an off-list with Steve I am extending freeze by 3 days to make
up for late announcement of freeze.
So if there are other things besides the Sample Data Import plug-in that
people would have committed had there been 3 days notice, let me know
about those too.

--James
Post by James Crook
Steve,
If you would like to delay the release to give time to fix the crash
bug, do the packaging steps and have Gale do preliminary test of the
Sample Data Import plug in, then I'm OK to give an extra 3 days. That
would also give the translators 3 extra days, which I am sure they would
welcome.
I think 3 days warning WOULD have been reasonable warning for freeze, so
I am not OK to give more than 3 days for this. From my perspective,
from what I am hearing so far, the plug-in isn't actually ready yet and
should anyway have been held over to 2.1.4. I'd happily be proved wrong
on that, and it would give another feature for the announce message.
If it is just that the wording in the documentation and the big red
alert there that is massively over cautious, then a change to the
documentation (and packaging) alone might be enough.
--James.
Post by Steve the Fiddle
Post by James Crook
Post by Gale Andrews
Was its inclusion agreed somewhere?
Well, there is doer decides - but it looks to me as if this is an
attempt to add this to the release after we are frozen, as it is not
currently in linux, mac or windows project at the moment.
I'd like it to be on record that the plug-in was committed,
*and_documented_in_the_manual* within 24 hours of James writing (in a
conversation with Paul) "so current plan is to go into freeze tomorrow".
The plug-in has been in the GitHub Zip file, and the Mac nightly since that
time. I had forgotten the (undocumented) "packaging" steps, and did not
notice the error until the next Windows "nightly" came out on 22nd November.
Steve
------------------------------------------------------------------------------
Gale Andrews
2016-11-23 17:55:44 UTC
Permalink
James, please give UTC time and date for new start of freeze so there are
no misunderstandings.

Note that Leland stated that although Mac builds do pick up new plugins
because of how the installation script works, it is still an error that Sample
Data Import (if it is to be in 2.1.3) is not in the Xcode project file
( mac/Audacity.xcodeproj/project.pbxproj ).


Gale
Post by James Crook
Following an off-list with Steve I am extending freeze by 3 days to make
up for late announcement of freeze.
So if there are other things besides the Sample Data Import plug-in that
people would have committed had there been 3 days notice, let me know
about those too.
--James
Post by James Crook
Steve,
If you would like to delay the release to give time to fix the crash
bug, do the packaging steps and have Gale do preliminary test of the
Sample Data Import plug in, then I'm OK to give an extra 3 days. That
would also give the translators 3 extra days, which I am sure they would
welcome.
I think 3 days warning WOULD have been reasonable warning for freeze, so
I am not OK to give more than 3 days for this. From my perspective,
from what I am hearing so far, the plug-in isn't actually ready yet and
should anyway have been held over to 2.1.4. I'd happily be proved wrong
on that, and it would give another feature for the announce message.
If it is just that the wording in the documentation and the big red
alert there that is massively over cautious, then a change to the
documentation (and packaging) alone might be enough.
--James.
Post by Steve the Fiddle
Post by James Crook
Post by Gale Andrews
Was its inclusion agreed somewhere?
Well, there is doer decides - but it looks to me as if this is an
attempt to add this to the release after we are frozen, as it is not
currently in linux, mac or windows project at the moment.
I'd like it to be on record that the plug-in was committed,
*and_documented_in_the_manual* within 24 hours of James writing (in a
conversation with Paul) "so current plan is to go into freeze tomorrow".
The plug-in has been in the GitHub Zip file, and the Mac nightly since that
time. I had forgotten the (undocumented) "packaging" steps, and did not
notice the error until the next Windows "nightly" came out on 22nd November.
Steve
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Steve the Fiddle
2016-11-23 18:31:49 UTC
Permalink
Post by Gale Andrews
James, please give UTC time and date for new start of freeze so there are
no misunderstandings.
Note that Leland stated that although Mac builds do pick up new plugins
because of how the installation script works, it is still an error that Sample
Data Import (if it is to be in 2.1.3) is not in the Xcode project file
( mac/Audacity.xcodeproj/project.pbxproj ).
OK, so how do we add it?

Steve
Post by Gale Andrews
Gale
Post by James Crook
Following an off-list with Steve I am extending freeze by 3 days to make
up for late announcement of freeze.
So if there are other things besides the Sample Data Import plug-in that
people would have committed had there been 3 days notice, let me know
about those too.
--James
Post by James Crook
Steve,
If you would like to delay the release to give time to fix the crash
bug, do the packaging steps and have Gale do preliminary test of the
Sample Data Import plug in, then I'm OK to give an extra 3 days. That
would also give the translators 3 extra days, which I am sure they would
welcome.
I think 3 days warning WOULD have been reasonable warning for freeze, so
I am not OK to give more than 3 days for this. From my perspective,
from what I am hearing so far, the plug-in isn't actually ready yet and
should anyway have been held over to 2.1.4. I'd happily be proved wrong
on that, and it would give another feature for the announce message.
If it is just that the wording in the documentation and the big red
alert there that is massively over cautious, then a change to the
documentation (and packaging) alone might be enough.
--James.
Post by Steve the Fiddle
Post by James Crook
Post by Gale Andrews
Was its inclusion agreed somewhere?
Well, there is doer decides - but it looks to me as if this is an
attempt to add this to the release after we are frozen, as it is not
currently in linux, mac or windows project at the moment.
I'd like it to be on record that the plug-in was committed,
*and_documented_in_the_manual* within 24 hours of James writing (in a
conversation with Paul) "so current plan is to go into freeze
tomorrow".
Post by James Crook
Post by James Crook
Post by Steve the Fiddle
The plug-in has been in the GitHub Zip file, and the Mac nightly since
that
Post by James Crook
Post by James Crook
Post by Steve the Fiddle
time. I had forgotten the (undocumented) "packaging" steps, and did not
notice the error until the next Windows "nightly" came out on 22nd
November.
Post by James Crook
Post by James Crook
Post by Steve the Fiddle
Steve
------------------------------------------------------------
------------------
Post by James Crook
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Gale Andrews
2016-11-23 19:07:52 UTC
Permalink
Post by Steve the Fiddle
Post by Gale Andrews
James, please give UTC time and date for new start of freeze so there are
no misunderstandings.
Note that Leland stated that although Mac builds do pick up new plugins
because of how the installation script works, it is still an error that Sample
Data Import (if it is to be in 2.1.3) is not in the Xcode project file
( mac/Audacity.xcodeproj/project.pbxproj ).
OK, so how do we add it?
I believe the new file has to be added in Xcode and then the project saved.

It should produce a change that looks like this:
https://github.com/audacity/audacity/commit/2b8ba09 .


Gale
Post by Steve the Fiddle
Post by Gale Andrews
Post by James Crook
Following an off-list with Steve I am extending freeze by 3 days to make
up for late announcement of freeze.
So if there are other things besides the Sample Data Import plug-in that
people would have committed had there been 3 days notice, let me know
about those too.
--James
Post by James Crook
Steve,
If you would like to delay the release to give time to fix the crash
bug, do the packaging steps and have Gale do preliminary test of the
Sample Data Import plug in, then I'm OK to give an extra 3 days. That
would also give the translators 3 extra days, which I am sure they would
welcome.
I think 3 days warning WOULD have been reasonable warning for freeze, so
I am not OK to give more than 3 days for this. From my perspective,
from what I am hearing so far, the plug-in isn't actually ready yet and
should anyway have been held over to 2.1.4. I'd happily be proved wrong
on that, and it would give another feature for the announce message.
If it is just that the wording in the documentation and the big red
alert there that is massively over cautious, then a change to the
documentation (and packaging) alone might be enough.
--James.
Post by Steve the Fiddle
Post by James Crook
Post by Gale Andrews
Was its inclusion agreed somewhere?
Well, there is doer decides - but it looks to me as if this is an
attempt to add this to the release after we are frozen, as it is not
currently in linux, mac or windows project at the moment.
I'd like it to be on record that the plug-in was committed,
*and_documented_in_the_manual* within 24 hours of James writing (in a
conversation with Paul) "so current plan is to go into freeze tomorrow".
The plug-in has been in the GitHub Zip file, and the Mac nightly since that
time. I had forgotten the (undocumented) "packaging" steps, and did not
notice the error until the next Windows "nightly" came out on 22nd November.
Steve
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
James Crook
2016-11-23 21:01:31 UTC
Permalink
Gale, I have extended the freeze, not reset the freeze start date! That
means we won't be building RC1 until 4th December or later. Translators
have until midnight GMT 1st December, whereas previously it was
midnight GMT 28th Nov.

In the next three days Steve can add his Sample Import Plug-in. Say
until midnight GMT 26th Nov.
You can add your wording change (if it seems non contentious and bearing
in mind that translators already are working from the current .pot, so
it is mainly for the benefit of the English version and manual)

Anyone else with changes that need to go in can check with me, and that
is ongoing until release, even when we are doing RCs. Once we're doing
RCs I'm unlikely to say yes, except for P1s that you agree are P1s too.

--James.
Post by Gale Andrews
James, please give UTC time and date for new start of freeze so there are
no misunderstandings.
Note that Leland stated that although Mac builds do pick up new plugins
because of how the installation script works, it is still an error that Sample
Data Import (if it is to be in 2.1.3) is not in the Xcode project file
( mac/Audacity.xcodeproj/project.pbxproj ).
Gale
Post by James Crook
Following an off-list with Steve I am extending freeze by 3 days to make
up for late announcement of freeze.
So if there are other things besides the Sample Data Import plug-in that
people would have committed had there been 3 days notice, let me know
about those too.
--James
Post by James Crook
Steve,
If you would like to delay the release to give time to fix the crash
bug, do the packaging steps and have Gale do preliminary test of the
Sample Data Import plug in, then I'm OK to give an extra 3 days. That
would also give the translators 3 extra days, which I am sure they would
welcome.
I think 3 days warning WOULD have been reasonable warning for freeze, so
I am not OK to give more than 3 days for this. From my perspective,
from what I am hearing so far, the plug-in isn't actually ready yet and
should anyway have been held over to 2.1.4. I'd happily be proved wrong
on that, and it would give another feature for the announce message.
If it is just that the wording in the documentation and the big red
alert there that is massively over cautious, then a change to the
documentation (and packaging) alone might be enough.
--James.
Post by Steve the Fiddle
Post by James Crook
Post by Gale Andrews
Was its inclusion agreed somewhere?
Well, there is doer decides - but it looks to me as if this is an
attempt to add this to the release after we are frozen, as it is not
currently in linux, mac or windows project at the moment.
I'd like it to be on record that the plug-in was committed,
*and_documented_in_the_manual* within 24 hours of James writing (in a
conversation with Paul) "so current plan is to go into freeze tomorrow".
The plug-in has been in the GitHub Zip file, and the Mac nightly since that
time. I had forgotten the (undocumented) "packaging" steps, and did not
notice the error until the next Windows "nightly" came out on 22nd November.
Steve
------------------------------------------------------------------------------
Gale Andrews
2016-11-24 01:12:17 UTC
Permalink
Post by James Crook
Gale, I have extended the freeze, not reset the freeze start date!
I don't know what you are doing, that is why I ask for clarity!

.
Post by James Crook
That means we won't be building RC1 until 4th December or later. Translators
have until midnight GMT 1st December, whereas previously it was midnight GMT
28th Nov.
GMT is the same as UTC right now. Does it mean 23:59 UTC 30 November?
Post by James Crook
In the next three days Steve can add his Sample Import Plug-in. Say
until midnight GMT 26th Nov.
You can add your wording change (if it seems non contentious and bearing
in mind that translators already are working from the current .pot, so
it is mainly for the benefit of the English version and manual)
OK, if there seems sufficient consensus. I assume it means 23:59 UTC 25
November.


Gale
Post by James Crook
Anyone else with changes that need to go in can check with me, and that
is ongoing until release, even when we are doing RCs. Once we're doing
RCs I'm unlikely to say yes, except for P1s that you agree are P1s too.
--James.
Post by Gale Andrews
James, please give UTC time and date for new start of freeze so there are
no misunderstandings.
Note that Leland stated that although Mac builds do pick up new plugins
because of how the installation script works, it is still an error that Sample
Data Import (if it is to be in 2.1.3) is not in the Xcode project file
( mac/Audacity.xcodeproj/project.pbxproj ).
Gale
Post by James Crook
Following an off-list with Steve I am extending freeze by 3 days to make
up for late announcement of freeze.
So if there are other things besides the Sample Data Import plug-in that
people would have committed had there been 3 days notice, let me know
about those too.
--James
Post by James Crook
Steve,
If you would like to delay the release to give time to fix the crash
bug, do the packaging steps and have Gale do preliminary test of the
Sample Data Import plug in, then I'm OK to give an extra 3 days. That
would also give the translators 3 extra days, which I am sure they would
welcome.
I think 3 days warning WOULD have been reasonable warning for freeze, so
I am not OK to give more than 3 days for this. From my perspective,
from what I am hearing so far, the plug-in isn't actually ready yet and
should anyway have been held over to 2.1.4. I'd happily be proved wrong
on that, and it would give another feature for the announce message.
If it is just that the wording in the documentation and the big red
alert there that is massively over cautious, then a change to the
documentation (and packaging) alone might be enough.
--James.
Post by Steve the Fiddle
Post by James Crook
Post by Gale Andrews
Was its inclusion agreed somewhere?
Well, there is doer decides - but it looks to me as if this is an
attempt to add this to the release after we are frozen, as it is not
currently in linux, mac or windows project at the moment.
I'd like it to be on record that the plug-in was committed,
*and_documented_in_the_manual* within 24 hours of James writing (in a
conversation with Paul) "so current plan is to go into freeze tomorrow".
The plug-in has been in the GitHub Zip file, and the Mac nightly since that
time. I had forgotten the (undocumented) "packaging" steps, and did not
notice the error until the next Windows "nightly" came out on 22nd November.
Steve
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Gale Andrews
2016-11-22 17:17:02 UTC
Permalink
Post by Steve the Fiddle
Post by Gale Andrews
If you don't add your new plugin to
* win/Projects/Audacity/Audacity.vcxproj
* win/Projects/Audacity/Audacity.vcxproj.filters
then fairly obviously it won't get into the Windows build. I can add
it for Windows shortly if no-one else beats me to it.
Rather harsh Gale. It obviously wasn't obvious to me, which is why I asked.
Post by Gale Andrews
The plugin needs to be added to the Mac project too using Xcode.
According to its documentation, the plugin appears to be a crash risk if
user tries to import a file it does not support. Was its inclusion agreed
somewhere?
Yes, about 4 years ago when I wrote Sample Data Export. It's been on my ToDo
list since then. Iirc you were, at the time, quite keen on having the
ability to import as well as export sample data.
Perhaps I thought it should be on the Nyquist Plugin Downloads page?

I think if it is to be added to Audacity (now or later) it may need to be
made easier to handle files exported from Sample Data Export (yes
I have RTFM).

I'll post that about on the -quality list.


Gale
Post by Steve the Fiddle
The risk of crashing is actually quite low. The effect is a lot less "risky"
than the Nyquist Prompt effect, but there is probably greater temptation
for users, so better to overstate the risk with a prominent warning. This is
also why the effect will only accept files that have a .txt file extension.
In most cases, invalid data will simply produce an error.
Steve
Post by Gale Andrews
Gale
Post by Steve the Fiddle
The Windows Nightly for 22nd Nov (Zip) does not contain the new Sample Data
Import plug-in. Why is that and what needs to be done to correct it?
Steve
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Loading...