Discussion:
[Audacity-devel] Build broken on Linux
Steve the Fiddle
2016-09-19 17:21:02 UTC
Permalink
Linux build broken by https://github.com/audacity/audacity/commit/d63ffa123ee

Steve

------------------------------------------------------------------------------
Paul Licameli
2016-09-19 17:29:34 UTC
Permalink
Can you quote me the errors?
PRL
Post by Steve the Fiddle
Linux build broken by https://github.com/audacity/
audacity/commit/d63ffa123ee
Steve
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
James Crook
2016-09-19 18:17:17 UTC
Permalink
Paul,

Please just check on Travis
https://travis-ci.org/audacity/audacity/builds
That is what Travis is for! It shows the build breakings. If you
scroll down you will see the actual build log.



Menus.cpp: In member function ‘void AudacityProject::HandleAlign(int,
bool)’:
Menus.cpp:5891:23: error: ‘DBL_MAX’ was not declared in this scope
double minOffset = DBL_MAX;
^
make[2]: *** [audacity-Menus.o] Error 1



If you are unsure of a build, or have made a lot of changes, push it to
your own GitHub master first and view your own log, before pushing to
audacity master.

--James.
Post by Paul Licameli
Can you quote me the errors?
PRL
Post by Steve the Fiddle
Linux build broken by https://github.com/audacity/
audacity/commit/d63ffa123ee
Steve
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Paul Licameli
2016-09-19 19:48:31 UTC
Permalink
Post by James Crook
Paul,
Please just check on Travis
https://travis-ci.org/audacity/audacity/builds
That is what Travis is for! It shows the build breakings. If you scroll
down you will see the actual build log.
Hm, I don't know why I don't get the email notifications I should.
Post by James Crook
Menus.cpp: In member function ‘void AudacityProject::HandleAlign(int,
Menus.cpp:5891:23: error: ‘DBL_MAX’ was not declared in this scope
double minOffset = DBL_MAX;
^
make[2]: *** [audacity-Menus.o] Error 1
Okay, just a missing #include <cfloat>

PRL
Post by James Crook
If you are unsure of a build, or have made a lot of changes, push it to
your own GitHub master first and view your own log, before pushing to
audacity master.
--James.
Can you quote me the errors?
PRL
Linux build broken by https://github.com/audacity/
audacity/commit/d63ffa123ee
Steve
------------------------------------------------------------
------------------
_______________________________________________
------------------------------------------------------------------------------
_______________________________________________
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Steve the Fiddle
2016-09-20 09:57:38 UTC
Permalink
Given the ongoing purge to update the code to more recent C++
standards, why use the ancient C macro DBL_MAX rather than
std::numeric_limits<double>::max() ?

Steve
Post by Paul Licameli
Post by James Crook
Paul,
Please just check on Travis
https://travis-ci.org/audacity/audacity/builds
That is what Travis is for! It shows the build breakings. If you scroll
down you will see the actual build log.
Hm, I don't know why I don't get the email notifications I should.
Post by James Crook
Menus.cpp: In member function ‘void AudacityProject::HandleAlign(int,
Menus.cpp:5891:23: error: ‘DBL_MAX’ was not declared in this scope
double minOffset = DBL_MAX;
^
make[2]: *** [audacity-Menus.o] Error 1
Okay, just a missing #include <cfloat>
PRL
Post by James Crook
If you are unsure of a build, or have made a lot of changes, push it to
your own GitHub master first and view your own log, before pushing to
audacity master.
--James.
Can you quote me the errors?
PRL
On Mon, Sep 19, 2016 at 1:21 PM, Steve the Fiddle
Linux build broken by https://github.com/audacity/
audacity/commit/d63ffa123ee
Steve
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Paul Licameli
2016-09-20 10:41:40 UTC
Permalink
Good question. I don't have a very compelling answer. I felt like using a
short name rather than a repeated phrase in all the places that needed
changing, and the legacy C library already defined this one. Yes, this
goes against my dislike of macros otherwise.

What I would like better is that in some header I could write
constexpr HUGE_TIME = std::numeric_limits<double>::max();

But we can't use constexpr with the Visual Studio 2013 compiler.

The important thing was to a name that rather than the arbitrary constant
1000000000.0 that was used in several places as "a big time". Better to
have a name than a repeated numeric literal, and better to use the real
largest representable value.

PRL
Post by Steve the Fiddle
Given the ongoing purge to update the code to more recent C++
standards, why use the ancient C macro DBL_MAX rather than
std::numeric_limits<double>::max() ?
Steve
Post by Paul Licameli
Post by James Crook
Paul,
Please just check on Travis
https://travis-ci.org/audacity/audacity/builds
That is what Travis is for! It shows the build breakings. If you
scroll
Post by Paul Licameli
Post by James Crook
down you will see the actual build log.
Hm, I don't know why I don't get the email notifications I should.
Post by James Crook
Menus.cpp: In member function ‘void AudacityProject::HandleAlign(int,
Menus.cpp:5891:23: error: ‘DBL_MAX’ was not declared in this scope
double minOffset = DBL_MAX;
^
make[2]: *** [audacity-Menus.o] Error 1
Okay, just a missing #include <cfloat>
PRL
Post by James Crook
If you are unsure of a build, or have made a lot of changes, push it to
your own GitHub master first and view your own log, before pushing to
audacity master.
--James.
Can you quote me the errors?
PRL
On Mon, Sep 19, 2016 at 1:21 PM, Steve the Fiddle
Linux build broken by https://github.com/audacity/
audacity/commit/d63ffa123ee
Steve
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
Post by Paul Licameli
Post by James Crook
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
Post by Paul Licameli
Post by James Crook
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
Post by Paul Licameli
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Steve the Fiddle
2016-09-19 18:43:45 UTC
Permalink
Post by Paul Licameli
Can you quote me the errors?
https://travis-ci.org/audacity/audacity/

Steve
Post by Paul Licameli
PRL
Post by Steve the Fiddle
Linux build broken by
https://github.com/audacity/audacity/commit/d63ffa123ee
Steve
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Loading...