Paul Licameli
2017-06-09 17:02:16 UTC
Listing some minor appearance issues -- biased toward the Mac that I do
most of my work on these days:
Not necessarily problems, and not specific to any theme:
1. So far, we let it stand, that the Close and Mute buttons do not
impinge on the left and top borders of TrackControlPanel, whereas they did
in 2.1.3, appearing a little more raised.
2. Menu button and Solo have now (c11fd1d) been made consistent -- so
they DO slightly impinge on the RIGHT border, but they did not in 2.1.3.
3. When there is no Solo (Tracks, Behaviors preferences), Mute is now
centered, good. But the Minimize button below it does not center the same
way. Does anyone find that unaesthetic?
4. Menu button overlaps bottom track border slightly, which it did not
in 2.1.3. Is this intended?
And theme-specific:
1. Extra lines about the Minimize, Mute, and Solo buttons are no longer
drawn, as they were in 2.1.3. So even Classic changes it appearance, and I
think the top and left bevels of the buttons in unselected tracks contrast
too little with the background of the panel. I suppose that was why code
was once added to make extra lines. (In Light theme, there is a small
change to the background of the buttons themselves, which is just enough to
improve contrast.) So should the lines be restored, just for Classic? Or
should Classic make some small color change?
2. Mousing over the Transport toolbar buttons in Light theme on Mac
looks a bit wrong at the borders -- as if the bitmaps have been clipped one
or two pixels at the top.
3. In Classic theme, on Mac, mousing over the menu buttons on the
recording and playback meters makes too little change of appearance, less
so than the clear change in 2.1.3, and as in (2) the changes near the
borders of the bitmap don't look right.
That's all for now, there may be others.
PRL
most of my work on these days:
Not necessarily problems, and not specific to any theme:
1. So far, we let it stand, that the Close and Mute buttons do not
impinge on the left and top borders of TrackControlPanel, whereas they did
in 2.1.3, appearing a little more raised.
2. Menu button and Solo have now (c11fd1d) been made consistent -- so
they DO slightly impinge on the RIGHT border, but they did not in 2.1.3.
3. When there is no Solo (Tracks, Behaviors preferences), Mute is now
centered, good. But the Minimize button below it does not center the same
way. Does anyone find that unaesthetic?
4. Menu button overlaps bottom track border slightly, which it did not
in 2.1.3. Is this intended?
And theme-specific:
1. Extra lines about the Minimize, Mute, and Solo buttons are no longer
drawn, as they were in 2.1.3. So even Classic changes it appearance, and I
think the top and left bevels of the buttons in unselected tracks contrast
too little with the background of the panel. I suppose that was why code
was once added to make extra lines. (In Light theme, there is a small
change to the background of the buttons themselves, which is just enough to
improve contrast.) So should the lines be restored, just for Classic? Or
should Classic make some small color change?
2. Mousing over the Transport toolbar buttons in Light theme on Mac
looks a bit wrong at the borders -- as if the bitmaps have been clipped one
or two pixels at the top.
3. In Classic theme, on Mac, mousing over the menu buttons on the
recording and playback meters makes too little change of appearance, less
so than the clear change in 2.1.3, and as in (2) the changes near the
borders of the bitmap don't look right.
That's all for now, there may be others.
PRL