[Audacity-devel] Two week pause before RC3.

OK - this one
http://bugzilla.audacityteam.org/show_bug.cgi?id=1591

Simple fix so worth it to save embarrassment.

Actually the slow verification extends to other apps as well e.g.
VLC and Filezilla. Perhaps not so slow as Audacity, but it's there.

The "damaged" problem if a different user runs Audacity than
installs it does seem to be unique to us, so "partial support" would
probably have to remain.

In any case, 1567 might behave differently on other susceptible
machines than mine. We won't know until 2.1.3 is out.

Are we going to try and do without fork and crash, by removing
.DS_Store files from SessionData top level on launch? I do think
there is a chance that would work.

Post by James Crook
1596 Crash opening menu of some AU effects
Paul has a fix. Let's have it.
1595 Corrupting or truncating a .aup file leads to deletion of block files.
Paul has a fix. Let's have it.
1506 Linux: gcc 4.9 requirement not warned about until building.
Darrell probably has a fix. Let's have it (still using autoconf though)
1492 Using Scrub Ruler to start Scrub or then change to Seek removes the
selection
Should be an easy fix, and this is a P2.
1453 Effects that are no longer available still in the Effect menu,
which is a problem for previously shipped effects.
I'm looking to do the amelioration, that if you click on a missing
effect it tells you it is missing and is then removed. This has no
startup cost implication.

So is this for all effects, and will Nyquist effects now use this
system too for consistency, rather than be silently removed?

+1 for "no startup cost". Audacity is already too slow to start
on Windows with an HDD.

Gale

Post by James Crook
1446 (Mac and Linux) Audacity does not launch if TempDir is on a
FAT/exFAT file system
This is a regression, so it should (?) be easy to work out why it
happens now?
1597 Enh: Greater clarity over status of versions needed. (P4)
Motivated in part by Softpedia and others providing our Alphas for
download. This is also an enabler for creating a pool of engaged
testers during 2.2.0 development.
--James.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

James Crook

2017-02-24 16:30:07 UTC

OK - this one
http://bugzilla.audacityteam.org/show_bug.cgi?id=1591
Simple fix so worth it to save embarrassment.

Only a 'simple fix' if the user has installed to the same path as last
time, and on windows. Not averse to that much being done.

Post by Gale Andrews
Are we going to try and do without fork and crash, by removing
.DS_Store files from SessionData top level on launch? I do think there
is a chance that would work.

I think you're mis-guessing why removing .DS_Store files helps. I
think it unlikely that they in themselves are the problem. Rather it is
in combination with attempts to delete folders that contain them. I am
not averse to your idea being tried, but am much less hopeful than you
that it will help. Whereas I do think we have a good chance of actually
deleting 'empty' folders in the two-project multiproject wormcan case.

Post by James Crook
1453 Effects that are no longer available still in the Effect menu,
which is a problem for previously shipped effects.
I'm looking to do the amelioration, that if you click on a missing
effect it tells you it is missing and is then removed. This has no
startup cost implication.

So is this for all effects,

All missing effects that don't crash Audacity. [An updated multi-effect
3rd Party plug in might crash when you try to use an effect it does not
have any more]

Post by Gale Andrews
and will Nyquist effects now use this system too for consistency, rather than be silently removed?

As well, not instead. I don't think anyone else has bought in to your
argument that it is desirable to show effects that 'don't exist any
more' in the menus. Were it not for start up time, I'd rather, and I
think so would others, that they were all gone from the start.

Post by Gale Andrews
+1 for "no startup cost". Audacity is already too slow to start on Windows with an HDD.

Something we should measure and look at for 2.2.0? It may be the number
of DLLs that we load that slows us down. Possibly we could amalgamate
the wxWidgets DLLs into one for faster verification and loading.
http://stackoverflow.com/questions/145499/merge-several-native-dlls-into-one-dll

--James.

Gale Andrews

2017-02-24 18:50:17 UTC

OK - this one
http://bugzilla.audacityteam.org/show_bug.cgi?id=1591
Simple fix so worth it to save embarrassment.

Only a 'simple fix' if the user has installed to the same path as last
time, and on windows. Not averse to that much being done.

I see you've done it now, thanks. Installing over the top on Windows
is a common scenario, so personally I place high value on the fix.

We had already made comparable removals for Mac and Linux,
so this was an oversight.

Post by Gale Andrews
Are we going to try and do without fork and crash, by removing
.DS_Store files from SessionData top level on launch? I do think there
is a chance that would work.

I don't believe it is the files themselves. I think it could be interactions
between the files and the folders, where the interactions might not be
confined to deleting folders that contain them.

If I understand it, in the multi-project case and we close without save, we
aren't at the moment even trying to delete the folders that contain the
.DS_Store files, only to delete the .DS_Store files themselves. Is that
correct?

If so, then it seems to me that in this case, it's the mere presence of the
folders and their repopulation with .DS_Store files within a certain time
frame that is the problem. And if so, that repopulation could be a reason
bug 1567 occurs on launch.

It might not be the only reason.

Post by James Crook
I am not averse to your idea being tried, but am much less hopeful than you
that it will help.

I hope you will allow it to be tried, unless my reasoning above is false.

Post by James Crook
Whereas I do think we have a good chance of actually deleting 'empty' folders
in the two-project multiproject wormcan case.

Yes. I am 99% confident on that.

So is this for all effects,

All missing effects that don't crash Audacity. [An updated multi-effect
3rd Party plug in might crash when you try to use an effect it does not
have any more]

Post by Gale Andrews
and will Nyquist effects now use this system too for consistency, rather than be silently removed?

As well, not instead. I don't think anyone else has bought in to your
argument that it is desirable to show effects that 'don't exist any
more' in the menus.

I think you misrepresent my argument, which is that user should be
informed of the removal, not necessarily that the method of informing
should be to still show the plugin in the menu. The clear "advantage"
of that method however is that there is no startup time cost.

Generally we do like consistency, and it is inconsistent to show all
but one effect type in the menu when the plugin is missing. I think
we should be consistent here, unless you see a possible future
solution to the start up time cost for the non-text plugin types, so
that we show no missing plugins in the menus at all.

Post by James Crook
Were it not for start up time, I'd rather, and I think so would others,
that they were all gone from the start.

I don't think it's right to assume all missing effects are the result of
deliberate action by the user, even if many are.

Even if there was no start up time cost for any of the plugin types,
I still argue the information of removal should be "somewhere" -
if not in a "Missing" category in Plug-in Manager, then at least
in the log.

I'm thinking of practicalities of helping users who find a plugin
has vanished and they don't know why - it happens.

Post by Gale Andrews
+1 for "no startup cost". Audacity is already too slow to start on Windows with an HDD.

OK, though I don't think that discounts my points above.

IIRC, Leland already found that most of the time cost is associated
with the audio device routines we perform. I can look up what he
said sometime.

Gale

James Crook

2017-02-24 19:37:06 UTC

Post by Gale Andrews
I see you've done it now, thanks. Installing over the top on Windows
is a common scenario, so personally I place high value on the fix.

OK.

Post by Gale Andrews
I don't believe it is the files themselves. I think it could be interactions
between the files and the folders, where the interactions might not be
confined to deleting folders that contain them.
If I understand it, in the multi-project case and we close without save, we
aren't at the moment even trying to delete the folders that contain the
.DS_Store files, only to delete the .DS_Store files themselves. Is that
correct?

My quick test on windows with two unnamed projects and and not saving
either, closing one at a time, we do at the end when we are closing
Audacity get rid of both project* projects completely, empty folders and
all.

At the intermediate stage, when only the first project has been closed,
its block files are removed but not its empty folders.

That's also what I expect from the code. Hence my question about steps
to reproduce on windows.

Post by Gale Andrews
If so, then it seems to me that in this case, it's the mere presence of the
folders and their repopulation with .DS_Store files within a certain time
frame that is the problem. And if so, that repopulation could be a reason
bug 1567 occurs on launch.
It might not be the only reason.

Post by James Crook
I am not averse to your idea being tried, but am much less hopeful than you
that it will help.

I hope you will allow it to be tried, unless my reasoning above is false.

Of course it can be tried out, and we will learn more. I won't be
pushing for it to be tried though. Given wacky things like fork and
crash actually help significantly, I'm not going to rule out anything
from possibly helping.

Post by James Crook
Whereas I do think we have a good chance of actually deleting 'empty' folders
in the two-project multiproject wormcan case.

Yes. I am 99% confident on that.

Post by Gale Andrews
and will Nyquist effects now use this system too for consistency, rather than be silently removed?

As well, not instead. I don't think anyone else has bought in to your
argument that it is desirable to show effects that 'don't exist any
more' in the menus.

I'm not keen on informing users at start up (even just once). We have
enough pop-ups at start-up already.
I don't think we do need to or should inform users that deleted plug ins
have gone. If we do in fact need to, the add/remove plugins manager is
the place to do it. IMO.

Post by Gale Andrews
Generally we do like consistency, and it is inconsistent to show all
but one effect type in the menu when the plugin is missing.

+1 to both points.

Post by Gale Andrews
I think we should be consistent here, unless you see a possible future
solution to the start up time cost for the non-text plugin types, so
that we show no missing plugins in the menus at all.

I think a reasonable solution for 2.2.0 is to remove those missing
plug-ins from the menu that we can do at practically zero start-up cost.

Then when a user clicks on a missing plug-in, we can inform them of the
problem, and start scanning for more missing plug-ins. It will still
take a while, but it will only happen when there is at least one
troublesome missing plug-in. It can be a background thread even, that
does not stop them getting on with their work.

But all that is an enhancement, and we need to agree/discuss
enhancements. Someone may have a better idea that goes with more
extensive redesign of the manage plug-ins dialog.

Post by James Crook
Were it not for start up time, I'd rather, and I think so would others,
that they were all gone from the start.

I don't think it's right to assume all missing effects are the result of
deliberate action by the user, even if many are.
Even if there was no start up time cost for any of the plugin types,
I still argue the information of removal should be "somewhere" -
if not in a "Missing" category in Plug-in Manager, then at least
in the log.

Certainly can add to the log.
One related point is that a log becomes useless if we treat it as a
dumping ground for messages. So an approach I often use is to show the
first ten of some event, and then offer an interface that allows
querying the current count of different event types.

Post by Gale Andrews
I'm thinking of practicalities of helping users who find a plugin
has vanished and they don't know why - it happens.

That suggests an html log with a link to the manual.
"Missing plug-ins were removed from the menus. See [missing plug-ins]."

Post by James Crook
Something we should measure and look at for 2.2.0? It may be the number
of DLLs that we load that slows us down. Possibly we could amalgamate
the wxWidgets DLLs into one for faster verification and loading.
http://stackoverflow.com/questions/145499/merge-several-native-dlls-into-one-dll

IIRC, Leland already found that most of the time cost is associated
with the audio device routines we perform. I can look up what he
said sometime.

We *might* be able to save some of that by caching a scan, and using the
cache, if it works, and only doing a full scan otherwise. Would mean
some mods to PortAudio, probably.

--James.

Gale Andrews

2017-02-24 16:41:33 UTC

I also propose we fix 1599 (P2):
"Cannot paste clipboard text into label unless content already on
Audacity clipboard"

given I understand Steve has a fix.

Gale

Post by James Crook
As RM I have decided that we will take a 2 week pause before generating
RC3 to clear some accumulated P2s. I've set IS_ALPHA back to 1. We are
still in FREEZE.
Bug fixes for any of the below (except 1597) can be checked in without
checking with me first. Other fixes may be OK too, but ask me.
1567 Mac Sierra: LAME, FFmpeg and some plugins disappear. (intermittent)
I think we can fix the specific multiproject case by tracing it to see
why folders are left in that case. I still intend to announce only
partial support for Sierra with 2.1.3, e.g. because of the slow
gatekeeper checks gale has seen.
1596 Crash opening menu of some AU effects
Paul has a fix. Let's have it.
1595 Corrupting or truncating a .aup file leads to deletion of block files.
Paul has a fix. Let's have it.
1506 Linux: gcc 4.9 requirement not warned about until building.
Darrell probably has a fix. Let's have it (still using autoconf though)
1492 Using Scrub Ruler to start Scrub or then change to Seek removes the
selection
Should be an easy fix, and this is a P2.
1453 Effects that are no longer available still in the Effect menu,
which is a problem for previously shipped effects.
I'm looking to do the amelioration, that if you click on a missing
effect it tells you it is missing and is then removed. This has no
startup cost implication.
1446 (Mac and Linux) Audacity does not launch if TempDir is on a
FAT/exFAT file system
This is a regression, so it should (?) be easy to work out why it
happens now?
1597 Enh: Greater clarity over status of versions needed. (P4)
Motivated in part by Softpedia and others providing our Alphas for
download. This is also an enabler for creating a pool of engaged
testers during 2.2.0 development.
--James.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

David Bailes

2017-02-24 16:47:55 UTC

I've got a straightforward fix for bug 1550:
https://github.com/DavidBailes/audacity/commit/06dc9073ab35e939dbcae1f578df3d0aea427ceb

David.

Post by James Crook
1567 Mac Sierra: LAME, FFmpeg and some plugins disappear. (intermittent)
I think we can fix the specific multiproject case by tracing it to see
why folders are left in that case. I still intend to announce only
partial support for Sierra with 2.1.3, e.g. because of the slow
gatekeeper checks gale has seen.
1596 Crash opening menu of some AU effects
Paul has a fix. Let's have it.
1595 Corrupting or truncating a .aup file leads to deletion of block files.
Paul has a fix. Let's have it.
1506 Linux: gcc 4.9 requirement not warned about until building.
Darrell probably has a fix. Let's have it (still using autoconf though)
1492 Using Scrub Ruler to start Scrub or then change to Seek removes the
selection
Should be an easy fix, and this is a P2.
1453 Effects that are no longer available still in the Effect menu,
which is a problem for previously shipped effects.
I'm looking to do the amelioration, that if you click on a missing
effect it tells you it is missing and is then removed. This has no
startup cost implication.
1446 (Mac and Linux) Audacity does not launch if TempDir is on a
FAT/exFAT file system
This is a regression, so it should (?) be easy to work out why it
happens now?
1597 Enh: Greater clarity over status of versions needed. (P4)
Motivated in part by Softpedia and others providing our Alphas for
download. This is also an enabler for creating a pool of engaged
testers during 2.2.0 development.
--James.
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

James Crook

2017-02-24 18:18:58 UTC

I've now added a table on wiki to track the "Pause before for RC3"
Bugzilla entries.
http://wiki.audacityteam.org/wiki/Next_Release

Post by David Bailes
https://github.com/DavidBailes/audacity/commit/06dc9073ab35e939dbcae1f578df3d0aea427ceb
David.

Thanks. +1. Committed.

Post by David Bailes
"Cannot paste clipboard text into label unless content already on
Audacity clipboard"
given I understand Steve has a fix.

Thanks. +1. Committed.

--James.

Steve the Fiddle

2017-02-24 18:33:41 UTC

I've also got some fixes:
bug 1566
bug 1573
bug 1576
bug 1574
bug 470 (residual issue)

The fixes are in my Nyquist branch:
https://github.com/SteveDaulton/audacity/commits/Nyquist

Steve

Post by James Crook
I've now added a table on wiki to track the "Pause before for RC3"
Bugzilla entries.
http://wiki.audacityteam.org/wiki/Next_Release

Post by David Bailes
https://github.com/DavidBailes/audacity/commit/06dc9073ab35e939dbcae1f578df3d0aea427ceb
David.

Thanks. +1. Committed.

Post by David Bailes
"Cannot paste clipboard text into label unless content already on
Audacity clipboard"
given I understand Steve has a fix.

Thanks. +1. Committed.
--James.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

James Crook

2017-02-24 19:08:23 UTC

Thanks for these.
They look good and safe, so I committed them.

Rather than just
'Bug 1576'
I cut and paste the title from the Bugzilla page:
'Bug 1576 - Assert when New Length is zero in Change Speed effect'

Otherwise it is hard to know what the commit is about from the title
alone. Could you do that in future for bugfix commits? Thanks!

--James.

Post by Steve the Fiddle
bug 1566
bug 1573
bug 1576
bug 1574
bug 470 (residual issue)
https://github.com/SteveDaulton/audacity/commits/Nyquist
Steve

Steve the Fiddle

2017-02-24 19:57:43 UTC

Post by James Crook
Thanks for these.
They look good and safe, so I committed them.
Rather than just
'Bug 1576'
'Bug 1576 - Assert when New Length is zero in Change Speed effect'
Otherwise it is hard to know what the commit is about from the title
alone. Could you do that in future for bugfix commits? Thanks!

Will do.

Steve

Post by James Crook
--James.

Post by Steve the Fiddle
bug 1566
bug 1573
bug 1576
bug 1574
bug 470 (residual issue)
https://github.com/SteveDaulton/audacity/commits/Nyquist
Steve

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Darrell Walisser

2017-02-24 19:59:23 UTC

Post by James Crook
As RM I have decided that we will take a 2 week pause before generating
RC3 to clear some accumulated P2s. I've set IS_ALPHA back to 1. We are
still in FREEZE.
...

Post by James Crook
1506 Linux: gcc 4.9 requirement not warned about until building.
Darrell probably has a fix. Let's have it (still using autoconf though)
âhttps://github.com/audacity/audacity/pull/184

James Crook

2017-02-24 23:17:53 UTC

Big thanks to everyone who has been contributing fixes and related today
for RC3.
We now have 18 target bugzilla bugs, and 12 already DEVEL-FIXMADE.

--James.

Gale Andrews

2017-03-03 03:50:25 UTC

I would like to propose Leland's fix for:
http://bugzilla.audacityteam.org/show_bug.cgi?id=290

"(Mac) LAME: Audacity looks for LAME in a restricted folder
that Mac no longer supports" for 2.1.3.

The fix and the new LAME installer/new LAME 3.99.5 version
that we "found" have been thoroughly tested by Leland and
myself (hence it couldn't be got ready before now).

This will save some, perhaps many, users fruitlessly trying to
enable LAME using the current installer that we recommend.

Gale

Post by James Crook
Big thanks to everyone who has been contributing fixes and related today
for RC3.
We now have 18 target bugzilla bugs, and 12 already DEVEL-FIXMADE.
--James.

James Crook

2017-03-03 19:33:32 UTC