Discussion:
Mac build failure
(too old to reply)
Steve the Fiddle
2017-07-19 21:52:11 UTC
Permalink
I'm still not able to build on Mac after commit ef9745b93
Consequently I've been able to make no progress with the Mac nightlies.

Attached is a build log for a release build of commit f725e937a45c2f

Steve
Henric Jungheim
2017-07-20 09:41:55 UTC
Permalink
Post by Steve the Fiddle
I'm still not able to build on Mac after commit ef9745b93
Consequently I've been able to make no progress with the Mac nightlies.
Attached is a build log for a release build of commit f725e937a45c2f
Steve
...

CompileC build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.o /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm normal i386 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
cd /Users/steve/Documents/sourcecode/Audacity/mac
export LANG=en_US.US-ASCII
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c++ -arch i386 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=c++11 -stdlib=libstdc++ -gmodules -Wno-trigraphs -
fpascal-strings -O3 -Wno-missing-field-initializers -Wno-missing-prototypes -Werror=return-type -Wno-implicit-atomic-properties -Wno-arc-repeated-use-of-weak -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparenthese
s -Wswitch -Wno-unused-function -Wno-unused-label -Wno-unused-parameter -Wno-unused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wno-constant-conversion -Wno-int-conversion -
Wno-bool-conversion -Wno-enum-conversion -Wno-shorten-64-to-32 -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wno-undeclared-selector -Wno-deprecated-implementations -Wno-c++11-extensions -DAUDACITY_DLL_API= -DBUILDING_AUDACITY=1 -DAUDACITY_DLL_API= -
isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.6 -g -fvisibility-inlines-hidden -Wno-sign-c
onversion -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Audacity.hmap -I../include -I../mac/config/i386/src -I../mac -I../src -I../src/blockfile -I../src/commands -I../src/effects -I../src/export -I../src/import -I..
/src/ondemand -I../src/prefs -I../src/toolbars -I../src/tracks -I../src/widgets -I../src/xml -I../src/effects/audiounits -I../src/effects/ladspa -I../src/effects/lv2 -I../src/effects/nyquist -I../src/effects/vamp -I../src/effects/VST -I../src/tracks/labeltrack -I
../src/tracks/playabletrack -I../src/tracks/timetrack -I../src/tracks/ui -I../src/tracks/labeltrack/ui -I../src/tracks/playabletrack/notetrack -I../src/tracks/playabletrack/ui -I../src/tracks/playabletrack/wavetrack -I../src/tracks/timetrack/ui -I../src/tracks/pl
ayabletrack/notetrack/ui -I../src/tracks/playabletrack/wavetrack/ui -I../lib-src/FileDialog -I../lib-src/libflac/include -I../lib-src/libid3tag -I../lib-src/lame -I../mac/config/i386/lib-src/libmad -I../lib-src/libmad -I../lib-src/libogg/include -I../lib-src/libn
yquist/nyq -I../mac/config/i386/lib-src/libsndfile -I../mac/config/i386/lib-src/libsndfile/src -I../lib-src/libsndfile/src -I../lib-src/libsoxr/src -I../lib-src/libvamp -I../lib-src/libvorbis/include -I../lib-src/portaudio-v19/include -I../lib-src/portmixer/px_co
mmon -I../lib-src/portsmf -I../mac/config/i386/lib-src/soundtouch -I../mac/config/i386/lib-src/soundtouch/include -I../lib-src/soundtouch/include -I../lib-src/lv2/lv2 -I../lib-src/lv2/lilv -I../lib-src/lv2/suil -I../lib-src/twolame/libtwolame -I../mac/config/i386
/lib-src/sbsms -I../mac/config/i386/lib-src/sbsms/src -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Release/include -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources/i386 -I/Users/steve/Documents/
sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources -F/Users/steve/Documents/sourcecode/Audacity/mac/build/Release -I/usr/local/lib/wx/include/osx_cocoa-unicode-3.0-release -I/usr/local/include/wx-3.0-release -D_FILE_OFFSET_BITS=64
-DwxDEBUG_LEVEL=0 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__ -D__WXOSX_COCOA__ -I../lib-src/ffmpeg -D__STDC_CONSTANT_MACROS -include /var/folders/21/pqhrvx9975z5rld64w7svgj00000gn/C/com.apple.DeveloperTools/7.1.1-7B1005/Xcode/SharedPrecompiledHeaders/AudacityHeaders-eg
edevncjkubjvexfkespbmatymt/AudacityHeaders.h -MMD -MT dependencies -MF /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.d --serialize-diagnostics /Users/steve/Documents/sourcecode/Aud
acity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.dia -c /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm -o /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Releas
e/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
In file included from /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm:40:
In file included from /usr/local/include/wx-3.0-release/wx/osx/private.h:11:
/usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h:242:77: error: control reaches end of non-void function [-Werror,-Wreturn-type]
bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen = fullScreen; }
^
1 error generated.
Steve the Fiddle
2017-07-20 10:27:22 UTC
Permalink
Post by Henric Jungheim
Post by Steve the Fiddle
I'm still not able to build on Mac after commit ef9745b93
Consequently I've been able to make no progress with the Mac nightlies.
Attached is a build log for a release build of commit f725e937a45c2f
Steve
...
CompileC build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.o /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm normal i386 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
cd /Users/steve/Documents/sourcecode/Audacity/mac
export LANG=en_US.US-ASCII
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c++ -arch i386 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=c++11 -stdlib=libstdc++ -gmodules -Wno-trigraphs -
fpascal-strings -O3 -Wno-missing-field-initializers -Wno-missing-prototypes -Werror=return-type -Wno-implicit-atomic-properties -Wno-arc-repeated-use-of-weak -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparenthese
s -Wswitch -Wno-unused-function -Wno-unused-label -Wno-unused-parameter -Wno-unused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wno-constant-conversion -Wno-int-conversion -
Wno-bool-conversion -Wno-enum-conversion -Wno-shorten-64-to-32 -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wno-undeclared-selector -Wno-deprecated-implementations -Wno-c++11-extensions -DAUDACITY_DLL_API= -DBUILDING_AUDACITY=1 -DAUDACITY_DLL_API= -
isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.6 -g -fvisibility-inlines-hidden -Wno-sign-c
onversion -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Audacity.hmap -I../include -I../mac/config/i386/src -I../mac -I../src -I../src/blockfile -I../src/commands -I../src/effects -I../src/export -I../src/import -I..
/src/ondemand -I../src/prefs -I../src/toolbars -I../src/tracks -I../src/widgets -I../src/xml -I../src/effects/audiounits -I../src/effects/ladspa -I../src/effects/lv2 -I../src/effects/nyquist -I../src/effects/vamp -I../src/effects/VST -I../src/tracks/labeltrack -I
../src/tracks/playabletrack -I../src/tracks/timetrack -I../src/tracks/ui -I../src/tracks/labeltrack/ui -I../src/tracks/playabletrack/notetrack -I../src/tracks/playabletrack/ui -I../src/tracks/playabletrack/wavetrack -I../src/tracks/timetrack/ui -I../src/tracks/pl
ayabletrack/notetrack/ui -I../src/tracks/playabletrack/wavetrack/ui -I../lib-src/FileDialog -I../lib-src/libflac/include -I../lib-src/libid3tag -I../lib-src/lame -I../mac/config/i386/lib-src/libmad -I../lib-src/libmad -I../lib-src/libogg/include -I../lib-src/libn
yquist/nyq -I../mac/config/i386/lib-src/libsndfile -I../mac/config/i386/lib-src/libsndfile/src -I../lib-src/libsndfile/src -I../lib-src/libsoxr/src -I../lib-src/libvamp -I../lib-src/libvorbis/include -I../lib-src/portaudio-v19/include -I../lib-src/portmixer/px_co
mmon -I../lib-src/portsmf -I../mac/config/i386/lib-src/soundtouch -I../mac/config/i386/lib-src/soundtouch/include -I../lib-src/soundtouch/include -I../lib-src/lv2/lv2 -I../lib-src/lv2/lilv -I../lib-src/lv2/suil -I../lib-src/twolame/libtwolame -I../mac/config/i386
/lib-src/sbsms -I../mac/config/i386/lib-src/sbsms/src -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Release/include -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources/i386 -I/Users/steve/Documents/
sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources -F/Users/steve/Documents/sourcecode/Audacity/mac/build/Release -I/usr/local/lib/wx/include/osx_cocoa-unicode-3.0-release -I/usr/local/include/wx-3.0-release -D_FILE_OFFSET_BITS=64
-DwxDEBUG_LEVEL=0 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__ -D__WXOSX_COCOA__ -I../lib-src/ffmpeg -D__STDC_CONSTANT_MACROS -include /var/folders/21/pqhrvx9975z5rld64w7svgj00000gn/C/com.apple.DeveloperTools/7.1.1-7B1005/Xcode/SharedPrecompiledHeaders/AudacityHeaders-eg
edevncjkubjvexfkespbmatymt/AudacityHeaders.h -MMD -MT dependencies -MF /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.d --serialize-diagnostics /Users/steve/Documents/sourcecode/Aud
acity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.dia -c /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm -o /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Releas
e/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
/usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h:242:77: error: control reaches end of non-void function [-Werror,-Wreturn-type]
bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen = fullScreen; }
^
1 error generated.
Thanks Henric,

Yes I can see there's an error in
/usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h

bool NotifyFullScreen( bool fullscreen ) {m_isFullScreen = fullscreen; }

There's no bool return value.

Which seems to come from this commit:
https://github.com/audacity/wxWidgets/commit/85106af5ce61eef45d2f416908a4ff7b64728124

Steve
Steve the Fiddle
2017-07-20 10:36:20 UTC
Permalink
Post by Steve the Fiddle
Post by Henric Jungheim
Post by Steve the Fiddle
I'm still not able to build on Mac after commit ef9745b93
Consequently I've been able to make no progress with the Mac nightlies.
Attached is a build log for a release build of commit f725e937a45c2f
Steve
...
CompileC build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.o /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm normal i386 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
cd /Users/steve/Documents/sourcecode/Audacity/mac
export LANG=en_US.US-ASCII
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c++ -arch i386 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=c++11 -stdlib=libstdc++ -gmodules -Wno-trigraphs -
fpascal-strings -O3 -Wno-missing-field-initializers -Wno-missing-prototypes -Werror=return-type -Wno-implicit-atomic-properties -Wno-arc-repeated-use-of-weak -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparenthese
s -Wswitch -Wno-unused-function -Wno-unused-label -Wno-unused-parameter -Wno-unused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wno-constant-conversion -Wno-int-conversion -
Wno-bool-conversion -Wno-enum-conversion -Wno-shorten-64-to-32 -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wno-undeclared-selector -Wno-deprecated-implementations -Wno-c++11-extensions -DAUDACITY_DLL_API= -DBUILDING_AUDACITY=1 -DAUDACITY_DLL_API= -
isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.6 -g -fvisibility-inlines-hidden -Wno-sign-c
onversion -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Audacity.hmap -I../include -I../mac/config/i386/src -I../mac -I../src -I../src/blockfile -I../src/commands -I../src/effects -I../src/export -I../src/import -I..
/src/ondemand -I../src/prefs -I../src/toolbars -I../src/tracks -I../src/widgets -I../src/xml -I../src/effects/audiounits -I../src/effects/ladspa -I../src/effects/lv2 -I../src/effects/nyquist -I../src/effects/vamp -I../src/effects/VST -I../src/tracks/labeltrack -I
../src/tracks/playabletrack -I../src/tracks/timetrack -I../src/tracks/ui -I../src/tracks/labeltrack/ui -I../src/tracks/playabletrack/notetrack -I../src/tracks/playabletrack/ui -I../src/tracks/playabletrack/wavetrack -I../src/tracks/timetrack/ui -I../src/tracks/pl
ayabletrack/notetrack/ui -I../src/tracks/playabletrack/wavetrack/ui -I../lib-src/FileDialog -I../lib-src/libflac/include -I../lib-src/libid3tag -I../lib-src/lame -I../mac/config/i386/lib-src/libmad -I../lib-src/libmad -I../lib-src/libogg/include -I../lib-src/libn
yquist/nyq -I../mac/config/i386/lib-src/libsndfile -I../mac/config/i386/lib-src/libsndfile/src -I../lib-src/libsndfile/src -I../lib-src/libsoxr/src -I../lib-src/libvamp -I../lib-src/libvorbis/include -I../lib-src/portaudio-v19/include -I../lib-src/portmixer/px_co
mmon -I../lib-src/portsmf -I../mac/config/i386/lib-src/soundtouch -I../mac/config/i386/lib-src/soundtouch/include -I../lib-src/soundtouch/include -I../lib-src/lv2/lv2 -I../lib-src/lv2/lilv -I../lib-src/lv2/suil -I../lib-src/twolame/libtwolame -I../mac/config/i386
/lib-src/sbsms -I../mac/config/i386/lib-src/sbsms/src -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Release/include -I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources/i386 -I/Users/steve/Documents/
sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources -F/Users/steve/Documents/sourcecode/Audacity/mac/build/Release -I/usr/local/lib/wx/include/osx_cocoa-unicode-3.0-release -I/usr/local/include/wx-3.0-release -D_FILE_OFFSET_BITS=64
-DwxDEBUG_LEVEL=0 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__ -D__WXOSX_COCOA__ -I../lib-src/ffmpeg -D__STDC_CONSTANT_MACROS -include /var/folders/21/pqhrvx9975z5rld64w7svgj00000gn/C/com.apple.DeveloperTools/7.1.1-7B1005/Xcode/SharedPrecompiledHeaders/AudacityHeaders-eg
edevncjkubjvexfkespbmatymt/AudacityHeaders.h -MMD -MT dependencies -MF /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.d --serialize-diagnostics /Users/steve/Documents/sourcecode/Aud
acity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.dia -c /Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm -o /Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Releas
e/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
/usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h:242:77: error: control reaches end of non-void function [-Werror,-Wreturn-type]
bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen = fullScreen; }
^
1 error generated.
Thanks Henric,
Yes I can see there's an error in
/usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h
bool NotifyFullScreen( bool fullscreen ) {m_isFullScreen = fullscreen; }
There's no bool return value.
https://github.com/audacity/wxWidgets/commit/85106af5ce61eef45d2f416908a4ff7b64728124
Which I see Paul told us about at the beginning of July
http://audacity.238276.n2.nabble.com/Change-your-wxWidgets-headers-for-Mac-td7581188.html

Any reason why this wasn't fixed?

Steve
Post by Steve the Fiddle
Steve
Paul Licameli
2017-07-20 11:37:32 UTC
Permalink
There is nothing to be fixed now in the source tree. As described there,
it should work if you do all the instructions to build Mac from nothing,
including the wxWidgets build and install with modifications. But if you
did not repeat that, then as the email says, you can make a small edit in
/usr/include and continue.

PRL
Post by Henric Jungheim
Post by Steve the Fiddle
Post by Henric Jungheim
Post by Steve the Fiddle
I'm still not able to build on Mac after commit ef9745b93
Consequently I've been able to make no progress with the Mac nightlies.
Attached is a build log for a release build of commit f725e937a45c2f
Steve
...
CompileC build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
/Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm
normal i386 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
Post by Steve the Fiddle
Post by Henric Jungheim
cd /Users/steve/Documents/sourcecode/Audacity/mac
export LANG=en_US.US-ASCII
/Applications/Xcode.app/Contents/Developer/Toolchains/
XcodeDefault.xctoolchain/usr/bin/clang -x objective-c++ -arch i386
-fmessage-length=0 -fdiagnostics-show-note-include-stack
-fmacro-backtrace-limit=0 -std=c++11 -stdlib=libstdc++ -gmodules
-Wno-trigraphs -
Post by Steve the Fiddle
Post by Henric Jungheim
fpascal-strings -O3 -Wno-missing-field-initializers
-Wno-missing-prototypes -Werror=return-type -Wno-implicit-atomic-properties
-Wno-arc-repeated-use-of-weak -Wno-non-virtual-dtor -Wno-overloaded-virtual
-Wno-exit-time-destructors -Wno-missing-braces -Wparenthese
Post by Steve the Fiddle
Post by Henric Jungheim
s -Wswitch -Wno-unused-function -Wno-unused-label -Wno-unused-parameter
-Wno-unused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized
-Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion
-Wno-constant-conversion -Wno-int-conversion -
Post by Steve the Fiddle
Post by Henric Jungheim
Wno-bool-conversion -Wno-enum-conversion -Wno-shorten-64-to-32
-Wno-newline-eof -Wno-selector -Wno-strict-selector-match
-Wno-undeclared-selector -Wno-deprecated-implementations
-Wno-c++11-extensions -DAUDACITY_DLL_API= -DBUILDING_AUDACITY=1
-DAUDACITY_DLL_API= -
Post by Steve the Fiddle
Post by Henric Jungheim
isysroot /Applications/Xcode.app/Contents/Developer/Platforms/
MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -fasm-blocks
-fstrict-aliasing -Wprotocol -Wdeprecated-declarations -Winvalid-offsetof
-mmacosx-version-min=10.6 -g -fvisibility-inlines-hidden -Wno-sign-c
Post by Steve the Fiddle
Post by Henric Jungheim
onversion -I/Users/steve/Documents/sourcecode/Audacity/mac/build/
Audacity.build/Release/Audacity.build/Audacity.hmap -I../include
-I../mac/config/i386/src -I../mac -I../src -I../src/blockfile
-I../src/commands -I../src/effects -I../src/export -I../src/import -I..
Post by Steve the Fiddle
Post by Henric Jungheim
/src/ondemand -I../src/prefs -I../src/toolbars -I../src/tracks
-I../src/widgets -I../src/xml -I../src/effects/audiounits
-I../src/effects/ladspa -I../src/effects/lv2 -I../src/effects/nyquist
-I../src/effects/vamp -I../src/effects/VST -I../src/tracks/labeltrack -I
Post by Steve the Fiddle
Post by Henric Jungheim
../src/tracks/playabletrack -I../src/tracks/timetrack
-I../src/tracks/ui -I../src/tracks/labeltrack/ui
-I../src/tracks/playabletrack/notetrack -I../src/tracks/playabletrack/ui
-I../src/tracks/playabletrack/wavetrack -I../src/tracks/timetrack/ui
-I../src/tracks/pl
Post by Steve the Fiddle
Post by Henric Jungheim
ayabletrack/notetrack/ui -I../src/tracks/playabletrack/wavetrack/ui
-I../lib-src/FileDialog -I../lib-src/libflac/include -I../lib-src/libid3tag
-I../lib-src/lame -I../mac/config/i386/lib-src/libmad -I../lib-src/libmad
-I../lib-src/libogg/include -I../lib-src/libn
Post by Steve the Fiddle
Post by Henric Jungheim
yquist/nyq -I../mac/config/i386/lib-src/libsndfile
-I../mac/config/i386/lib-src/libsndfile/src -I../lib-src/libsndfile/src
-I../lib-src/libsoxr/src -I../lib-src/libvamp
-I../lib-src/libvorbis/include -I../lib-src/portaudio-v19/include
-I../lib-src/portmixer/px_co
Post by Steve the Fiddle
Post by Henric Jungheim
mmon -I../lib-src/portsmf -I../mac/config/i386/lib-src/soundtouch
-I../mac/config/i386/lib-src/soundtouch/include -I../lib-src/soundtouch/include
-I../lib-src/lv2/lv2 -I../lib-src/lv2/lilv -I../lib-src/lv2/suil
-I../lib-src/twolame/libtwolame -I../mac/config/i386
Post by Steve the Fiddle
Post by Henric Jungheim
/lib-src/sbsms -I../mac/config/i386/lib-src/sbsms/src
-I/Users/steve/Documents/sourcecode/Audacity/mac/build/Release/include
-I/Users/steve/Documents/sourcecode/Audacity/mac/build/
Audacity.build/Release/Audacity.build/DerivedSources/i386
-I/Users/steve/Documents/
Post by Steve the Fiddle
Post by Henric Jungheim
sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources
-F/Users/steve/Documents/sourcecode/Audacity/mac/build/Release
-I/usr/local/lib/wx/include/osx_cocoa-unicode-3.0-release
-I/usr/local/include/wx-3.0-release -D_FILE_OFFSET_BITS=64
Post by Steve the Fiddle
Post by Henric Jungheim
-DwxDEBUG_LEVEL=0 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__
-D__WXOSX_COCOA__ -I../lib-src/ffmpeg -D__STDC_CONSTANT_MACROS -include
/var/folders/21/pqhrvx9975z5rld64w7svgj00000gn
/C/com.apple.DeveloperTools/7.1.1-7B1005/Xcode/SharedPrecompiledHeaders/
AudacityHeaders-eg
Post by Steve the Fiddle
Post by Henric Jungheim
edevncjkubjvexfkespbmatymt/AudacityHeaders.h -MMD -MT dependencies -MF
/Users/steve/Documents/sourcecode/Audacity/mac/build/
Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.d
--serialize-diagnostics /Users/steve/Documents/sourcecode/Aud
Post by Steve the Fiddle
Post by Henric Jungheim
acity/mac/build/Audacity.build/Release/Audacity.build/
Objects-normal/i386/FileDialogPrivate.dia -c /Users/steve/Documents/
sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm -o
/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Releas
Post by Steve the Fiddle
Post by Henric Jungheim
e/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
In file included from /Users/steve/Documents/
In file included from /usr/local/include/wx-3.0-
error: control reaches end of non-void function [-Werror,-Wreturn-type]
Post by Steve the Fiddle
Post by Henric Jungheim
bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen =
fullScreen; }
^
Post by Steve the Fiddle
Post by Henric Jungheim
1 error generated.
Thanks Henric,
Yes I can see there's an error in
/usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h
bool NotifyFullScreen( bool fullscreen ) {m_isFullScreen = fullscreen; }
There's no bool return value.
https://github.com/audacity/wxWidgets/commit/
85106af5ce61eef45d2f416908a4ff7b64728124
Which I see Paul told us about at the beginning of July
http://audacity.238276.n2.nabble.com/Change-your-
wxWidgets-headers-for-Mac-td7581188.html
Any reason why this wasn't fixed?
Steve
Post by Steve the Fiddle
Steve
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Steve the Fiddle
2017-07-20 11:47:59 UTC
Permalink
There is nothing to be fixed now in the source tree. As described there, it
should work if you do all the instructions to build Mac from nothing,
I did, and it doesn't.

If you follow the instructions in Build.txt to the letter, the build fails.

Here are the instructions:
https://github.com/audacity/audacity/blob/master/mac/Build.txt

Here is the patched wxWidgets that it tells you to download:
https://github.com/audacity/wxWidgets/tree/audacity-fixes

And here is the file with your bug:
https://github.com/audacity/wxWidgets/blob/audacity-fixes/include/wx/osx/cocoa/private.h
which is clearly NOT fixed because here is the error:
bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen = fullScreen; }

Steve
including the wxWidgets build and install with modifications. But if you
did not repeat that, then as the email says, you can make a small edit in
/usr/include and continue.
PRL
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
Post by Steve the Fiddle
I'm still not able to build on Mac after commit ef9745b93
Consequently I've been able to make no progress with the Mac nightlies.
Attached is a build log for a release build of commit f725e937a45c2f
Steve
...
CompileC
build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
/Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm
normal i386 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
cd /Users/steve/Documents/sourcecode/Audacity/mac
export LANG=en_US.US-ASCII
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
-x objective-c++ -arch i386 -fmessage-length=0
-fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=c++11
-stdlib=libstdc++ -gmodules -Wno-trigraphs -
fpascal-strings -O3 -Wno-missing-field-initializers
-Wno-missing-prototypes -Werror=return-type -Wno-implicit-atomic-properties
-Wno-arc-repeated-use-of-weak -Wno-non-virtual-dtor -Wno-overloaded-virtual
-Wno-exit-time-destructors -Wno-missing-braces -Wparenthese
s -Wswitch -Wno-unused-function -Wno-unused-label -Wno-unused-parameter
-Wno-unused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized
-Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion
-Wno-constant-conversion -Wno-int-conversion -
Wno-bool-conversion -Wno-enum-conversion -Wno-shorten-64-to-32
-Wno-newline-eof -Wno-selector -Wno-strict-selector-match
-Wno-undeclared-selector -Wno-deprecated-implementations
-Wno-c++11-extensions -DAUDACITY_DLL_API= -DBUILDING_AUDACITY=1
-DAUDACITY_DLL_API= -
isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk
-fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations
-Winvalid-offsetof -mmacosx-version-min=10.6 -g -fvisibility-inlines-hidden
-Wno-sign-c
onversion
-I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Audacity.hmap
-I../include -I../mac/config/i386/src -I../mac -I../src -I../src/blockfile
-I../src/commands -I../src/effects -I../src/export -I../src/import -I..
/src/ondemand -I../src/prefs -I../src/toolbars -I../src/tracks
-I../src/widgets -I../src/xml -I../src/effects/audiounits
-I../src/effects/ladspa -I../src/effects/lv2 -I../src/effects/nyquist
-I../src/effects/vamp -I../src/effects/VST -I../src/tracks/labeltrack -I
../src/tracks/playabletrack -I../src/tracks/timetrack
-I../src/tracks/ui -I../src/tracks/labeltrack/ui
-I../src/tracks/playabletrack/notetrack -I../src/tracks/playabletrack/ui
-I../src/tracks/playabletrack/wavetrack -I../src/tracks/timetrack/ui
-I../src/tracks/pl
ayabletrack/notetrack/ui -I../src/tracks/playabletrack/wavetrack/ui
-I../lib-src/FileDialog -I../lib-src/libflac/include -I../lib-src/libid3tag
-I../lib-src/lame -I../mac/config/i386/lib-src/libmad -I../lib-src/libmad
-I../lib-src/libogg/include -I../lib-src/libn
yquist/nyq -I../mac/config/i386/lib-src/libsndfile
-I../mac/config/i386/lib-src/libsndfile/src -I../lib-src/libsndfile/src
-I../lib-src/libsoxr/src -I../lib-src/libvamp -I../lib-src/libvorbis/include
-I../lib-src/portaudio-v19/include -I../lib-src/portmixer/px_co
mmon -I../lib-src/portsmf -I../mac/config/i386/lib-src/soundtouch
-I../mac/config/i386/lib-src/soundtouch/include
-I../lib-src/soundtouch/include -I../lib-src/lv2/lv2 -I../lib-src/lv2/lilv
-I../lib-src/lv2/suil -I../lib-src/twolame/libtwolame -I../mac/config/i386
/lib-src/sbsms -I../mac/config/i386/lib-src/sbsms/src
-I/Users/steve/Documents/sourcecode/Audacity/mac/build/Release/include
-I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources/i386
-I/Users/steve/Documents/
sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/DerivedSources
-F/Users/steve/Documents/sourcecode/Audacity/mac/build/Release
-I/usr/local/lib/wx/include/osx_cocoa-unicode-3.0-release
-I/usr/local/include/wx-3.0-release -D_FILE_OFFSET_BITS=64
-DwxDEBUG_LEVEL=0 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__
-D__WXOSX_COCOA__ -I../lib-src/ffmpeg -D__STDC_CONSTANT_MACROS -include
/var/folders/21/pqhrvx9975z5rld64w7svgj00000gn/C/com.apple.DeveloperTools/7.1.1-7B1005/Xcode/SharedPrecompiledHeaders/AudacityHeaders-eg
edevncjkubjvexfkespbmatymt/AudacityHeaders.h -MMD -MT dependencies -MF
/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.d
--serialize-diagnostics /Users/steve/Documents/sourcecode/Aud
acity/mac/build/Audacity.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.dia
-c
/Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/FileDialogPrivate.mm
-o
/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacity.build/Releas
e/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
In file included from
In file included from
control reaches end of non-void function [-Werror,-Wreturn-type]
bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen = fullScreen; }
^
1 error generated.
Thanks Henric,
Yes I can see there's an error in
/usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h
bool NotifyFullScreen( bool fullscreen ) {m_isFullScreen = fullscreen; }
There's no bool return value.
https://github.com/audacity/wxWidgets/commit/85106af5ce61eef45d2f416908a4ff7b64728124
Which I see Paul told us about at the beginning of July
http://audacity.238276.n2.nabble.com/Change-your-wxWidgets-headers-for-Mac-td7581188.html
Any reason why this wasn't fixed?
Steve
Post by Steve the Fiddle
Steve
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Paul Licameli
2017-07-20 12:49:48 UTC
Permalink
Post by Paul Licameli
There is nothing to be fixed now in the source tree. As described
there, it
Post by Paul Licameli
should work if you do all the instructions to build Mac from nothing,
I did, and it doesn't.
If you follow the instructions in Build.txt to the letter, the build fails.
https://github.com/audacity/audacity/blob/master/mac/Build.txt
https://github.com/audacity/wxWidgets/tree/audacity-fixes
https://github.com/audacity/wxWidgets/blob/audacity-fixes/
include/wx/osx/cocoa/private.h
bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen = fullScreen; }
Steve
I see, you didn't do this procedure, which is what I did for my own build:
http://wiki.audacityteam.org/wiki/Building_On_Mac#Using_wxWidgets_from_wxWidgets

Instead you follow the newer procedure of just getting our modified
wxWidgets source tree from GitHub.

I updated the patch files, which are part of Audacity's own source tree.

But I did not update our branch at the wxWidgets repository, to support
this newer way of doing it.

I will fix that at once.

PRL
Post by Paul Licameli
including the wxWidgets build and install with modifications. But if you
did not repeat that, then as the email says, you can make a small edit in
/usr/include and continue.
PRL
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
Post by Steve the Fiddle
I'm still not able to build on Mac after commit ef9745b93
Consequently I've been able to make no progress with the Mac nightlies.
Attached is a build log for a release build of commit f725e937a45c2f
Steve
...
CompileC
build/Audacity.build/Release/Audacity.build/Objects-normal/
i386/FileDialogPrivate.o
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
/Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/
FileDialogPrivate.mm
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
normal i386 objective-c++ com.apple.compilers.llvm.
clang.1_0.compiler
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
cd /Users/steve/Documents/sourcecode/Audacity/mac
export LANG=en_US.US-ASCII
/Applications/Xcode.app/Contents/Developer/Toolchains/
XcodeDefault.xctoolchain/usr/bin/clang
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-x objective-c++ -arch i386 -fmessage-length=0
-fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0
-std=c++11
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-stdlib=libstdc++ -gmodules -Wno-trigraphs -
fpascal-strings -O3 -Wno-missing-field-initializers
-Wno-missing-prototypes -Werror=return-type -Wno-implicit-atomic-
properties
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-Wno-arc-repeated-use-of-weak -Wno-non-virtual-dtor
-Wno-overloaded-virtual
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-Wno-exit-time-destructors -Wno-missing-braces -Wparenthese
s -Wswitch -Wno-unused-function -Wno-unused-label
-Wno-unused-parameter
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-Wno-unused-variable -Wunused-value -Wno-empty-body
-Wno-uninitialized
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants
-Wno-conversion
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-Wno-constant-conversion -Wno-int-conversion -
Wno-bool-conversion -Wno-enum-conversion -Wno-shorten-64-to-32
-Wno-newline-eof -Wno-selector -Wno-strict-selector-match
-Wno-undeclared-selector -Wno-deprecated-implementations
-Wno-c++11-extensions -DAUDACITY_DLL_API= -DBUILDING_AUDACITY=1
-DAUDACITY_DLL_API= -
isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/
MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations
-Winvalid-offsetof -mmacosx-version-min=10.6 -g
-fvisibility-inlines-hidden
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-Wno-sign-c
onversion
-I/Users/steve/Documents/sourcecode/Audacity/mac/build/
Audacity.build/Release/Audacity.build/Audacity.hmap
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I../include -I../mac/config/i386/src -I../mac -I../src
-I../src/blockfile
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I../src/commands -I../src/effects -I../src/export -I../src/import
-I..
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
/src/ondemand -I../src/prefs -I../src/toolbars -I../src/tracks
-I../src/widgets -I../src/xml -I../src/effects/audiounits
-I../src/effects/ladspa -I../src/effects/lv2 -I../src/effects/nyquist
-I../src/effects/vamp -I../src/effects/VST
-I../src/tracks/labeltrack -I
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
../src/tracks/playabletrack -I../src/tracks/timetrack
-I../src/tracks/ui -I../src/tracks/labeltrack/ui
-I../src/tracks/playabletrack/notetrack
-I../src/tracks/playabletrack/ui
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I../src/tracks/playabletrack/wavetrack -I../src/tracks/timetrack/ui
-I../src/tracks/pl
ayabletrack/notetrack/ui -I../src/tracks/playabletrack/wavetrack/ui
-I../lib-src/FileDialog -I../lib-src/libflac/include
-I../lib-src/libid3tag
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I../lib-src/lame -I../mac/config/i386/lib-src/libmad
-I../lib-src/libmad
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I../lib-src/libogg/include -I../lib-src/libn
yquist/nyq -I../mac/config/i386/lib-src/libsndfile
-I../mac/config/i386/lib-src/libsndfile/src
-I../lib-src/libsndfile/src
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I../lib-src/libsoxr/src -I../lib-src/libvamp
-I../lib-src/libvorbis/include
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I../lib-src/portaudio-v19/include -I../lib-src/portmixer/px_co
mmon -I../lib-src/portsmf -I../mac/config/i386/lib-src/soundtouch
-I../mac/config/i386/lib-src/soundtouch/include
-I../lib-src/soundtouch/include -I../lib-src/lv2/lv2
-I../lib-src/lv2/lilv
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I../lib-src/lv2/suil -I../lib-src/twolame/libtwolame
-I../mac/config/i386
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
/lib-src/sbsms -I../mac/config/i386/lib-src/sbsms/src
-I/Users/steve/Documents/sourcecode/Audacity/mac/build/
Release/include
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I/Users/steve/Documents/sourcecode/Audacity/mac/build/
Audacity.build/Release/Audacity.build/DerivedSources/i386
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I/Users/steve/Documents/
sourcecode/Audacity/mac/build/Audacity.build/Release/
Audacity.build/DerivedSources
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-F/Users/steve/Documents/sourcecode/Audacity/mac/build/Release
-I/usr/local/lib/wx/include/osx_cocoa-unicode-3.0-release
-I/usr/local/include/wx-3.0-release -D_FILE_OFFSET_BITS=64
-DwxDEBUG_LEVEL=0 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__
-D__WXOSX_COCOA__ -I../lib-src/ffmpeg -D__STDC_CONSTANT_MACROS
-include
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
/var/folders/21/pqhrvx9975z5rld64w7svgj00000gn
/C/com.apple.DeveloperTools/7.1.1-7B1005/Xcode/SharedPrecompiledHeaders/
AudacityHeaders-eg
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
edevncjkubjvexfkespbmatymt/AudacityHeaders.h -MMD -MT dependencies
-MF
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
/Users/steve/Documents/sourcecode/Audacity/mac/build/
Audacity.build/Release/Audacity.build/Objects-normal/
i386/FileDialogPrivate.d
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
--serialize-diagnostics /Users/steve/Documents/sourcecode/Aud
acity/mac/build/Audacity.build/Release/Audacity.build/
Objects-normal/i386/FileDialogPrivate.dia
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-c
/Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/
FileDialogPrivate.mm
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-o
/Users/steve/Documents/sourcecode/Audacity/mac/build/
Audacity.build/Releas
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
e/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
In file included from
/Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialog/mac/
In file included from
control reaches end of non-void function [-Werror,-Wreturn-type]
bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen = fullScreen; }
^
1 error generated.
Thanks Henric,
Yes I can see there's an error in
/usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h
bool NotifyFullScreen( bool fullscreen ) {m_isFullScreen =
fullscreen; }
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
There's no bool return value.
https://github.com/audacity/wxWidgets/commit/
85106af5ce61eef45d2f416908a4ff7b64728124
Post by Paul Licameli
Post by Steve the Fiddle
Which I see Paul told us about at the beginning of July
http://audacity.238276.n2.nabble.com/Change-your-
wxWidgets-headers-for-Mac-td7581188.html
Post by Paul Licameli
Post by Steve the Fiddle
Any reason why this wasn't fixed?
Steve
Post by Steve the Fiddle
Steve
------------------------------------------------------------
------------------
Post by Paul Licameli
Post by Steve the Fiddle
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
Post by Paul Licameli
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Paul Licameli
2017-07-20 13:06:38 UTC
Permalink
On Thu, Jul 20, 2017 at 7:47 AM, Steve the Fiddle <
Post by Paul Licameli
There is nothing to be fixed now in the source tree. As described
there, it
Post by Paul Licameli
should work if you do all the instructions to build Mac from nothing,
I did, and it doesn't.
If you follow the instructions in Build.txt to the letter, the build fails.
https://github.com/audacity/audacity/blob/master/mac/Build.txt
https://github.com/audacity/wxWidgets/tree/audacity-fixes
https://github.com/audacity/wxWidgets/blob/audacity-fixes/in
clude/wx/osx/cocoa/private.h
bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen = fullScreen; }
Steve
http://wiki.audacityteam.org/wiki/Building_On_Mac#Using_
wxWidgets_from_wxWidgets
Instead you follow the newer procedure of just getting our modified
wxWidgets source tree from GitHub.
I updated the patch files, which are part of Audacity's own source tree.
But I did not update our branch at the wxWidgets repository, to support
this newer way of doing it.
I will fix that at once.
PRL
I have updated the branch audacity-fixes.

PRL
Post by Paul Licameli
including the wxWidgets build and install with modifications. But if
you
Post by Paul Licameli
did not repeat that, then as the email says, you can make a small edit
in
Post by Paul Licameli
/usr/include and continue.
PRL
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
Post by Steve the Fiddle
I'm still not able to build on Mac after commit ef9745b93
Consequently I've been able to make no progress with the Mac nightlies.
Attached is a build log for a release build of commit
f725e937a45c2f
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
Post by Steve the Fiddle
Steve
...
CompileC
build/Audacity.build/Release/Audacity.build/Objects-normal/i
386/FileDialogPrivate.o
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
/Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialo
g/mac/FileDialogPrivate.mm
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
normal i386 objective-c++ com.apple.compilers.llvm.clang
.1_0.compiler
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
cd /Users/steve/Documents/sourcecode/Audacity/mac
export LANG=en_US.US-ASCII
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeD
efault.xctoolchain/usr/bin/clang
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-x objective-c++ -arch i386 -fmessage-length=0
-fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0
-std=c++11
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-stdlib=libstdc++ -gmodules -Wno-trigraphs -
fpascal-strings -O3 -Wno-missing-field-initializers
-Wno-missing-prototypes -Werror=return-type
-Wno-implicit-atomic-properties
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-Wno-arc-repeated-use-of-weak -Wno-non-virtual-dtor
-Wno-overloaded-virtual
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-Wno-exit-time-destructors -Wno-missing-braces -Wparenthese
s -Wswitch -Wno-unused-function -Wno-unused-label
-Wno-unused-parameter
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-Wno-unused-variable -Wunused-value -Wno-empty-body
-Wno-uninitialized
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants
-Wno-conversion
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-Wno-constant-conversion -Wno-int-conversion -
Wno-bool-conversion -Wno-enum-conversion -Wno-shorten-64-to-32
-Wno-newline-eof -Wno-selector -Wno-strict-selector-match
-Wno-undeclared-selector -Wno-deprecated-implementations
-Wno-c++11-extensions -DAUDACITY_DLL_API= -DBUILDING_AUDACITY=1
-DAUDACITY_DLL_API= -
isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.
platform/Developer/SDKs/MacOSX10.6.sdk
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations
-Winvalid-offsetof -mmacosx-version-min=10.6 -g
-fvisibility-inlines-hidden
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-Wno-sign-c
onversion
-I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audac
ity.build/Release/Audacity.build/Audacity.hmap
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I../include -I../mac/config/i386/src -I../mac -I../src
-I../src/blockfile
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I../src/commands -I../src/effects -I../src/export -I../src/import
-I..
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
/src/ondemand -I../src/prefs -I../src/toolbars -I../src/tracks
-I../src/widgets -I../src/xml -I../src/effects/audiounits
-I../src/effects/ladspa -I../src/effects/lv2
-I../src/effects/nyquist
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I../src/effects/vamp -I../src/effects/VST
-I../src/tracks/labeltrack -I
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
../src/tracks/playabletrack -I../src/tracks/timetrack
-I../src/tracks/ui -I../src/tracks/labeltrack/ui
-I../src/tracks/playabletrack/notetrack
-I../src/tracks/playabletrack/ui
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I../src/tracks/playabletrack/wavetrack
-I../src/tracks/timetrack/ui
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I../src/tracks/pl
ayabletrack/notetrack/ui -I../src/tracks/playabletrack/wavetrack/ui
-I../lib-src/FileDialog -I../lib-src/libflac/include
-I../lib-src/libid3tag
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I../lib-src/lame -I../mac/config/i386/lib-src/libmad
-I../lib-src/libmad
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I../lib-src/libogg/include -I../lib-src/libn
yquist/nyq -I../mac/config/i386/lib-src/libsndfile
-I../mac/config/i386/lib-src/libsndfile/src
-I../lib-src/libsndfile/src
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I../lib-src/libsoxr/src -I../lib-src/libvamp
-I../lib-src/libvorbis/include
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I../lib-src/portaudio-v19/include -I../lib-src/portmixer/px_co
mmon -I../lib-src/portsmf -I../mac/config/i386/lib-src/soundtouch
-I../mac/config/i386/lib-src/soundtouch/include
-I../lib-src/soundtouch/include -I../lib-src/lv2/lv2
-I../lib-src/lv2/lilv
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I../lib-src/lv2/suil -I../lib-src/twolame/libtwolame
-I../mac/config/i386
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
/lib-src/sbsms -I../mac/config/i386/lib-src/sbsms/src
-I/Users/steve/Documents/sourcecode/Audacity/mac/build/Relea
se/include
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I/Users/steve/Documents/sourcecode/Audacity/mac/build/Audac
ity.build/Release/Audacity.build/DerivedSources/i386
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-I/Users/steve/Documents/
sourcecode/Audacity/mac/build/Audacity.build/Release/Audacit
y.build/DerivedSources
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-F/Users/steve/Documents/sourcecode/Audacity/mac/build/Release
-I/usr/local/lib/wx/include/osx_cocoa-unicode-3.0-release
-I/usr/local/include/wx-3.0-release -D_FILE_OFFSET_BITS=64
-DwxDEBUG_LEVEL=0 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__
-D__WXOSX_COCOA__ -I../lib-src/ffmpeg -D__STDC_CONSTANT_MACROS
-include
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
/var/folders/21/pqhrvx9975z5rld64w7svgj00000gn/C/com.apple.
DeveloperTools/7.1.1-7B1005/Xcode/SharedPrecompiledHeaders
/AudacityHeaders-eg
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
edevncjkubjvexfkespbmatymt/AudacityHeaders.h -MMD -MT dependencies
-MF
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacit
y.build/Release/Audacity.build/Objects-normal/i386/FileDialogPrivate.d
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
--serialize-diagnostics /Users/steve/Documents/sourcecode/Aud
acity/mac/build/Audacity.build/Release/Audacity.build/Object
s-normal/i386/FileDialogPrivate.dia
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-c
/Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialo
g/mac/FileDialogPrivate.mm
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
-o
/Users/steve/Documents/sourcecode/Audacity/mac/build/Audacit
y.build/Releas
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
Post by Henric Jungheim
e/Audacity.build/Objects-normal/i386/FileDialogPrivate.o
In file included from
/Users/steve/Documents/sourcecode/Audacity/lib-src/FileDialo
In file included from
control reaches end of non-void function [-Werror,-Wreturn-type]
bool NotifyFullScreen( bool fullScreen ) { m_isFullScreen = fullScreen; }
^
1 error generated.
Thanks Henric,
Yes I can see there's an error in
/usr/local/include/wx-3.0-release/wx/osx/cocoa/private.h
bool NotifyFullScreen( bool fullscreen ) {m_isFullScreen =
fullscreen; }
Post by Paul Licameli
Post by Steve the Fiddle
Post by Steve the Fiddle
There's no bool return value.
https://github.com/audacity/wxWidgets/commit/85106af5ce61eef
45d2f416908a4ff7b64728124
Post by Paul Licameli
Post by Steve the Fiddle
Which I see Paul told us about at the beginning of July
http://audacity.238276.n2.nabble.com/Change-your-wxWidgets-
headers-for-Mac-td7581188.html
Post by Paul Licameli
Post by Steve the Fiddle
Any reason why this wasn't fixed?
Steve
Post by Steve the Fiddle
Steve
------------------------------------------------------------
------------------
Post by Paul Licameli
Post by Steve the Fiddle
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
Post by Paul Licameli
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Loading...