Discussion:
[Audacity-devel] Incorrect focus when opening effects
Steve the Fiddle
2016-09-28 09:51:07 UTC
Permalink
When opening the Nyquist Prompt, focus should be in the text box, but
on Linux, since https://github.com/audacity/audacity/commit/950f62a54
focus is on the "Load" button.

All other effects are also affected. Focus is one tab position past
where it should be.

Also, Alt+F6, which should, according to the documentation, navigate
to the next modeless window, now tabs through the controls in the
current window.

On Debian Stable Xfce, I can Alt+Shift+F6 through modeless windows
with or without commit 950f62a54.

I presume that Gale sees some improved behaviour on Ubuntu, but here
it's all bad :(

Steve

------------------------------------------------------------------------------
Gale Andrews
2016-09-28 14:27:29 UTC
Permalink
Thanks, Steve.

Yes, I do get the "one TAB too far" in effects on Ubuntu too.

ALT + F6 does nothing on Ubuntu in modal windows.

On Mac, focus is on the "Manage" button in effects, and has
been for a while now. but that's better than ENTER not
applying the effect.

When I tested Bugs 868 and 1196 on Ubuntu I was getting
multiple trappages in modeless dialogues or undocked toolbars,
so ALT + F6 / ALT + SHIFT + F6 really aren't working properly
there. Given a simulated (or actual) keypress totally fixed that,
I just went with Paul's suggestion to apply the fix to Linux.

It's no use if it's going to affect modal dialogues too, so please
go ahead and revert it, or I will later.



Gale


On 28 September 2016 at 10:51, Steve the Fiddle
Post by Steve the Fiddle
When opening the Nyquist Prompt, focus should be in the text box, but
on Linux, since https://github.com/audacity/audacity/commit/950f62a54
focus is on the "Load" button.
All other effects are also affected. Focus is one tab position past
where it should be.
Also, Alt+F6, which should, according to the documentation, navigate
to the next modeless window, now tabs through the controls in the
current window.
On Debian Stable Xfce, I can Alt+Shift+F6 through modeless windows
with or without commit 950f62a54.
I presume that Gale sees some improved behaviour on Ubuntu, but here
it's all bad :(
Steve
------------------------------------------------------------------------------
Gale Andrews
2016-09-28 15:35:15 UTC
Permalink
Post by Gale Andrews
Thanks, Steve.
Yes, I do get the "one TAB too far" in effects on Ubuntu too.
ALT + F6 does nothing on Ubuntu in modal windows.
On Mac, focus is on the "Manage" button in effects, and has
been for a while now. but that's better than ENTER not
applying the effect.
Oops that meant that the Manage button is "selected". So you
need plenty of TAB presses to move into the first control of
the effect,


Gale
Post by Gale Andrews
When I tested Bugs 868 and 1196 on Ubuntu I was getting
multiple trappages in modeless dialogues or undocked toolbars,
so ALT + F6 / ALT + SHIFT + F6 really aren't working properly
there. Given a simulated (or actual) keypress totally fixed that,
I just went with Paul's suggestion to apply the fix to Linux.
It's no use if it's going to affect modal dialogues too, so please
go ahead and revert it, or I will later.
Gale
On 28 September 2016 at 10:51, Steve the Fiddle
Post by Steve the Fiddle
When opening the Nyquist Prompt, focus should be in the text box, but
on Linux, since https://github.com/audacity/audacity/commit/950f62a54
focus is on the "Load" button.
All other effects are also affected. Focus is one tab position past
where it should be.
Also, Alt+F6, which should, according to the documentation, navigate
to the next modeless window, now tabs through the controls in the
current window.
On Debian Stable Xfce, I can Alt+Shift+F6 through modeless windows
with or without commit 950f62a54.
I presume that Gale sees some improved behaviour on Ubuntu, but here
it's all bad :(
Steve
------------------------------------------------------------------------------
Paul Licameli
2016-09-28 15:50:30 UTC
Permalink
Gale took some conditionally-compiled code I added, as Mac-only, and made
it Linux-also.

I am reexamining this, and the line

window->NavigateIn();

in AudacityApp.cpp is the cause of the change of button focus, but is not
necessary for the fix I intended.

Recall the problem I meant to solve was that the alt-f6 cycle on Mac got
trapped in modal dialogs. The changes in AudacityApp.cpp were meant to
complete that fix, in the case that you switch away from Audacity with
command-Tab (on Mac) and back again, and then attempt alt-f6 again.

So I will push this fix, after I figure out whether there is also an
alternative to using NavigateIn() in those two places in Menus.cpp.

PRL
Post by Gale Andrews
Post by Gale Andrews
Thanks, Steve.
Yes, I do get the "one TAB too far" in effects on Ubuntu too.
ALT + F6 does nothing on Ubuntu in modal windows.
On Mac, focus is on the "Manage" button in effects, and has
been for a while now. but that's better than ENTER not
applying the effect.
Oops that meant that the Manage button is "selected". So you
need plenty of TAB presses to move into the first control of
the effect,
Gale
Post by Gale Andrews
When I tested Bugs 868 and 1196 on Ubuntu I was getting
multiple trappages in modeless dialogues or undocked toolbars,
so ALT + F6 / ALT + SHIFT + F6 really aren't working properly
there. Given a simulated (or actual) keypress totally fixed that,
I just went with Paul's suggestion to apply the fix to Linux.
It's no use if it's going to affect modal dialogues too, so please
go ahead and revert it, or I will later.
Gale
On 28 September 2016 at 10:51, Steve the Fiddle
Post by Steve the Fiddle
When opening the Nyquist Prompt, focus should be in the text box, but
on Linux, since https://github.com/audacity/audacity/commit/950f62a54
focus is on the "Load" button.
All other effects are also affected. Focus is one tab position past
where it should be.
Also, Alt+F6, which should, according to the documentation, navigate
to the next modeless window, now tabs through the controls in the
current window.
On Debian Stable Xfce, I can Alt+Shift+F6 through modeless windows
with or without commit 950f62a54.
I presume that Gale sees some improved behaviour on Ubuntu, but here
it's all bad :(
Steve
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Paul Licameli
2016-09-28 15:57:40 UTC
Permalink
Okay, try again at 2e8ee5fe75789d60869b19fe1986c8d47cf0b995
Post by Paul Licameli
Gale took some conditionally-compiled code I added, as Mac-only, and made
it Linux-also.
I am reexamining this, and the line
window->NavigateIn();
in AudacityApp.cpp is the cause of the change of button focus, but is not
necessary for the fix I intended.
Recall the problem I meant to solve was that the alt-f6 cycle on Mac got
trapped in modal dialogs. The changes in AudacityApp.cpp were meant to
complete that fix, in the case that you switch away from Audacity with
command-Tab (on Mac) and back again, and then attempt alt-f6 again.
So I will push this fix, after I figure out whether there is also an
alternative to using NavigateIn() in those two places in Menus.cpp.
PRL
Post by Gale Andrews
Post by Gale Andrews
Thanks, Steve.
Yes, I do get the "one TAB too far" in effects on Ubuntu too.
ALT + F6 does nothing on Ubuntu in modal windows.
On Mac, focus is on the "Manage" button in effects, and has
been for a while now. but that's better than ENTER not
applying the effect.
Oops that meant that the Manage button is "selected". So you
need plenty of TAB presses to move into the first control of
the effect,
Gale
Post by Gale Andrews
When I tested Bugs 868 and 1196 on Ubuntu I was getting
multiple trappages in modeless dialogues or undocked toolbars,
so ALT + F6 / ALT + SHIFT + F6 really aren't working properly
there. Given a simulated (or actual) keypress totally fixed that,
I just went with Paul's suggestion to apply the fix to Linux.
It's no use if it's going to affect modal dialogues too, so please
go ahead and revert it, or I will later.
Gale
On 28 September 2016 at 10:51, Steve the Fiddle
Post by Steve the Fiddle
When opening the Nyquist Prompt, focus should be in the text box, but
on Linux, since https://github.com/audacity/audacity/commit/950f62a54
focus is on the "Load" button.
All other effects are also affected. Focus is one tab position past
where it should be.
Also, Alt+F6, which should, according to the documentation, navigate
to the next modeless window, now tabs through the controls in the
current window.
On Debian Stable Xfce, I can Alt+Shift+F6 through modeless windows
with or without commit 950f62a54.
I presume that Gale sees some improved behaviour on Ubuntu, but here
it's all bad :(
Steve
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Steve the Fiddle
2016-09-29 08:22:04 UTC
Permalink
Thanks Paul. That fixes the regression here.

The behaviour that I see now is the same as before:

Alt+F6 : Does nothing (the selected control blinks)
Alt+Shift+F6 : Navigates in reverse order through modeless windows.
Tab : Tabs to the next control in the current window
Alt+Tab : Navigates through open applications.
Focus is correct when opening a window.

The only thing that I see to be 'broken' is that Alt+F6 does not work,
but that's not a major practical problem as Alt+Shift+Tab does work. I
don't recall if Alt+F6 has ever worked.

(Gale) If the behaviour is the same on other Linux distros/desktops
and Audacity is released like this, I think we need a note in the
manual to say that Alt+F6 does not work on Linux
(http://alphamanual.audacityteam.org/man/Keyboard_Shortcut_Reference#Keyboard_focus).

Steve
Post by Paul Licameli
Okay, try again at 2e8ee5fe75789d60869b19fe1986c8d47cf0b995
Post by Paul Licameli
Gale took some conditionally-compiled code I added, as Mac-only, and made
it Linux-also.
I am reexamining this, and the line
window->NavigateIn();
in AudacityApp.cpp is the cause of the change of button focus, but is not
necessary for the fix I intended.
Recall the problem I meant to solve was that the alt-f6 cycle on Mac got
trapped in modal dialogs. The changes in AudacityApp.cpp were meant to
complete that fix, in the case that you switch away from Audacity with
command-Tab (on Mac) and back again, and then attempt alt-f6 again.
So I will push this fix, after I figure out whether there is also an
alternative to using NavigateIn() in those two places in Menus.cpp.
PRL
Post by Gale Andrews
Post by Gale Andrews
Thanks, Steve.
Yes, I do get the "one TAB too far" in effects on Ubuntu too.
ALT + F6 does nothing on Ubuntu in modal windows.
On Mac, focus is on the "Manage" button in effects, and has
been for a while now. but that's better than ENTER not
applying the effect.
Oops that meant that the Manage button is "selected". So you
need plenty of TAB presses to move into the first control of
the effect,
Gale
Post by Gale Andrews
When I tested Bugs 868 and 1196 on Ubuntu I was getting
multiple trappages in modeless dialogues or undocked toolbars,
so ALT + F6 / ALT + SHIFT + F6 really aren't working properly
there. Given a simulated (or actual) keypress totally fixed that,
I just went with Paul's suggestion to apply the fix to Linux.
It's no use if it's going to affect modal dialogues too, so please
go ahead and revert it, or I will later.
Gale
On 28 September 2016 at 10:51, Steve the Fiddle
Post by Steve the Fiddle
When opening the Nyquist Prompt, focus should be in the text box, but
on Linux, since https://github.com/audacity/audacity/commit/950f62a54
focus is on the "Load" button.
All other effects are also affected. Focus is one tab position past
where it should be.
Also, Alt+F6, which should, according to the documentation, navigate
to the next modeless window, now tabs through the controls in the
current window.
On Debian Stable Xfce, I can Alt+Shift+F6 through modeless windows
with or without commit 950f62a54.
I presume that Gale sees some improved behaviour on Ubuntu, but here
it's all bad :(
Steve
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Gale Andrews
2016-09-29 17:53:12 UTC
Permalink
Thanks for testing.

ALT + F6 has always worked on Ubuntu with GNOME or Unity as long
as I can remember, insofar that it at least moved once from wherever
the initial focus was. The problem was that ALT + F6 or ALT + SHIFT
+ F6 often got trapped after that, and could do so after switching to
another application and back to Audacity.

Are you completely free of any sort of trappage with ALT + SHIFT +
F6 - say if you have Contrast, Plot Spectrum and two floated toolbars
open?

ALT + F6 still works for me on Ubuntu. Might ALT + F6 be taken
as a system shortcut with Xfce?


Gale
Post by Steve the Fiddle
Thanks Paul. That fixes the regression here.
Alt+F6 : Does nothing (the selected control blinks)
Alt+Shift+F6 : Navigates in reverse order through modeless windows.
Tab : Tabs to the next control in the current window
Alt+Tab : Navigates through open applications.
Focus is correct when opening a window.
The only thing that I see to be 'broken' is that Alt+F6 does not work,
but that's not a major practical problem as Alt+Shift+Tab does work. I
don't recall if Alt+F6 has ever worked.
(Gale) If the behaviour is the same on other Linux distros/desktops
and Audacity is released like this, I think we need a note in the
manual to say that Alt+F6 does not work on Linux
(http://alphamanual.audacityteam.org/man/Keyboard_
Shortcut_Reference#Keyboard_focus).
Steve
Post by Paul Licameli
Okay, try again at 2e8ee5fe75789d60869b19fe1986c8d47cf0b995
Post by Paul Licameli
Gale took some conditionally-compiled code I added, as Mac-only, and
made
Post by Paul Licameli
Post by Paul Licameli
it Linux-also.
I am reexamining this, and the line
window->NavigateIn();
in AudacityApp.cpp is the cause of the change of button focus, but is
not
Post by Paul Licameli
Post by Paul Licameli
necessary for the fix I intended.
Recall the problem I meant to solve was that the alt-f6 cycle on Mac got
trapped in modal dialogs. The changes in AudacityApp.cpp were meant to
complete that fix, in the case that you switch away from Audacity with
command-Tab (on Mac) and back again, and then attempt alt-f6 again.
So I will push this fix, after I figure out whether there is also an
alternative to using NavigateIn() in those two places in Menus.cpp.
PRL
Post by Gale Andrews
Post by Gale Andrews
Thanks, Steve.
Yes, I do get the "one TAB too far" in effects on Ubuntu too.
ALT + F6 does nothing on Ubuntu in modal windows.
On Mac, focus is on the "Manage" button in effects, and has
been for a while now. but that's better than ENTER not
applying the effect.
Oops that meant that the Manage button is "selected". So you
need plenty of TAB presses to move into the first control of
the effect,
Gale
Post by Gale Andrews
When I tested Bugs 868 and 1196 on Ubuntu I was getting
multiple trappages in modeless dialogues or undocked toolbars,
so ALT + F6 / ALT + SHIFT + F6 really aren't working properly
there. Given a simulated (or actual) keypress totally fixed that,
I just went with Paul's suggestion to apply the fix to Linux.
It's no use if it's going to affect modal dialogues too, so please
go ahead and revert it, or I will later.
Gale
On 28 September 2016 at 10:51, Steve the Fiddle
Post by Steve the Fiddle
When opening the Nyquist Prompt, focus should be in the text box,
but
Post by Paul Licameli
Post by Paul Licameli
Post by Gale Andrews
Post by Gale Andrews
Post by Steve the Fiddle
on Linux, since https://github.com/audacity/
audacity/commit/950f62a54
Post by Paul Licameli
Post by Paul Licameli
Post by Gale Andrews
Post by Gale Andrews
Post by Steve the Fiddle
focus is on the "Load" button.
All other effects are also affected. Focus is one tab position past
where it should be.
Also, Alt+F6, which should, according to the documentation, navigate
to the next modeless window, now tabs through the controls in the
current window.
On Debian Stable Xfce, I can Alt+Shift+F6 through modeless windows
with or without commit 950f62a54.
I presume that Gale sees some improved behaviour on Ubuntu, but here
it's all bad :(
Steve
------------------------------------------------------------
------------------
Post by Paul Licameli
Post by Paul Licameli
Post by Gale Andrews
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
Post by Paul Licameli
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Steve the Fiddle
2016-09-29 18:06:25 UTC
Permalink
Post by Gale Andrews
Thanks for testing.
ALT + F6 has always worked on Ubuntu with GNOME or Unity as long
as I can remember, insofar that it at least moved once from wherever
the initial focus was. The problem was that ALT + F6 or ALT + SHIFT
+ F6 often got trapped after that, and could do so after switching to
another application and back to Audacity.
Are you completely free of any sort of trappage with ALT + SHIFT +
F6 - say if you have Contrast, Plot Spectrum and two floated toolbars
open?
Yes I can get trapped when toolbars are floating. It appears to happen
with some toolbars but not others.

Steve
Post by Gale Andrews
ALT + F6 still works for me on Ubuntu. Might ALT + F6 be taken
as a system shortcut with Xfce?
Gale
Post by Steve the Fiddle
Thanks Paul. That fixes the regression here.
Alt+F6 : Does nothing (the selected control blinks)
Alt+Shift+F6 : Navigates in reverse order through modeless windows.
Tab : Tabs to the next control in the current window
Alt+Tab : Navigates through open applications.
Focus is correct when opening a window.
The only thing that I see to be 'broken' is that Alt+F6 does not work,
but that's not a major practical problem as Alt+Shift+Tab does work. I
don't recall if Alt+F6 has ever worked.
(Gale) If the behaviour is the same on other Linux distros/desktops
and Audacity is released like this, I think we need a note in the
manual to say that Alt+F6 does not work on Linux
(http://alphamanual.audacityteam.org/man/Keyboard_Shortcut_Reference#Keyboard_focus).
Steve
Post by Paul Licameli
Okay, try again at 2e8ee5fe75789d60869b19fe1986c8d47cf0b995
On Wed, Sep 28, 2016 at 11:50 AM, Paul Licameli
Post by Paul Licameli
Gale took some conditionally-compiled code I added, as Mac-only, and made
it Linux-also.
I am reexamining this, and the line
window->NavigateIn();
in AudacityApp.cpp is the cause of the change of button focus, but is not
necessary for the fix I intended.
Recall the problem I meant to solve was that the alt-f6 cycle on Mac got
trapped in modal dialogs. The changes in AudacityApp.cpp were meant to
complete that fix, in the case that you switch away from Audacity with
command-Tab (on Mac) and back again, and then attempt alt-f6 again.
So I will push this fix, after I figure out whether there is also an
alternative to using NavigateIn() in those two places in Menus.cpp.
PRL
Post by Gale Andrews
Post by Gale Andrews
Thanks, Steve.
Yes, I do get the "one TAB too far" in effects on Ubuntu too.
ALT + F6 does nothing on Ubuntu in modal windows.
On Mac, focus is on the "Manage" button in effects, and has
been for a while now. but that's better than ENTER not
applying the effect.
Oops that meant that the Manage button is "selected". So you
need plenty of TAB presses to move into the first control of
the effect,
Gale
Post by Gale Andrews
When I tested Bugs 868 and 1196 on Ubuntu I was getting
multiple trappages in modeless dialogues or undocked toolbars,
so ALT + F6 / ALT + SHIFT + F6 really aren't working properly
there. Given a simulated (or actual) keypress totally fixed that,
I just went with Paul's suggestion to apply the fix to Linux.
It's no use if it's going to affect modal dialogues too, so please
go ahead and revert it, or I will later.
Gale
On 28 September 2016 at 10:51, Steve the Fiddle
Post by Steve the Fiddle
When opening the Nyquist Prompt, focus should be in the text box, but
on Linux, since
https://github.com/audacity/audacity/commit/950f62a54
focus is on the "Load" button.
All other effects are also affected. Focus is one tab position past
where it should be.
Also, Alt+F6, which should, according to the documentation, navigate
to the next modeless window, now tabs through the controls in the
current window.
On Debian Stable Xfce, I can Alt+Shift+F6 through modeless windows
with or without commit 950f62a54.
I presume that Gale sees some improved behaviour on Ubuntu, but here
it's all bad :(
Steve
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Loading...