Discussion:
[Audacity-devel] An unintended consequence of the fix for Bug1561
Paul Licameli
2016-12-25 18:10:01 UTC
Permalink
If you start Audacity from the command line with option -t, which brings up
the benchmark dialog, then the application no longer exits after the dialog
closes.

This can be easily fixed. Is this very important?

PRL
James Crook
2016-12-25 18:28:54 UTC
Permalink
Paul,
We can release fine with it unfixed.
IF you have a branch with a fix in, I am 90% likely to apply it.
A fix is likely to be safe.

I don't think we are ready to start doing RCs.
http://bugzilla.audacityteam.org/show_bug.cgi?id=1567 gives a reason not
to yet.
I'm also uneasy about the number of quite serious bugs that we're only
now finding/addressing like:
http://bugzilla.audacityteam.org/show_bug.cgi?id=1560
I need to put the windows wxfixes in with the mac wxfixes in our
wxwidgets repo too.

--James.
Post by Paul Licameli
If you start Audacity from the command line with option -t, which brings up
the benchmark dialog, then the application no longer exits after the dialog
closes.
This can be easily fixed. Is this very important?
PRL
Gale Andrews
2016-12-25 23:27:37 UTC
Permalink
I see I am not the only one failing to observe the season.

The benchamark problem is at:
http://bugzilla.audacityteam.org/show_bug.cgi?id=1488 .

For me, on Mac and Linux release builds, Audacity crashes after closing
Benchmark started from the Terminal. But I expected Audacity to stay open,
and so therefore does the bug report. I don't care too much if it can be made
to quit cleanly, as long as the documentation says that Audacity quit is
supposed to happen (it doesn't say so at help/audacity.1).

Does Audacity stay open if you use Help > Run Benchmark... from
inside a debug build then close the Benchmark? I don't have a recent
debug build.

It is not possible to lose data as a result of the crashes, AFAIK, because
--test ignores any file arguments that are also in the command.



Gale
Post by James Crook
Paul,
We can release fine with it unfixed.
IF you have a branch with a fix in, I am 90% likely to apply it.
A fix is likely to be safe.
I don't think we are ready to start doing RCs.
http://bugzilla.audacityteam.org/show_bug.cgi?id=1567 gives a reason not
to yet.
I'm also uneasy about the number of quite serious bugs that we're only
http://bugzilla.audacityteam.org/show_bug.cgi?id=1560
I need to put the windows wxfixes in with the mac wxfixes in our
wxwidgets repo too.
--James.
Post by Paul Licameli
If you start Audacity from the command line with option -t, which brings up
the benchmark dialog, then the application no longer exits after the dialog
closes.
This can be easily fixed. Is this very important?
PRL
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Paul Licameli
2016-12-26 01:10:50 UTC
Permalink
James, the change I suggested is now in my fork at commit id
a6bec5b1956d540d05b2e18fb018fa19d49d77af
Post by Gale Andrews
I see I am not the only one failing to observe the season.
http://bugzilla.audacityteam.org/show_bug.cgi?id=1488 .
For me, on Mac and Linux release builds, Audacity crashes after closing
Benchmark started from the Terminal. But I expected Audacity to stay open,
and so therefore does the bug report. I don't care too much if it can be made
to quit cleanly, as long as the documentation says that Audacity quit is
supposed to happen (it doesn't say so at help/audacity.1).
Does Audacity stay open if you use Help > Run Benchmark... from
inside a debug build then close the Benchmark? I don't have a recent
debug build.
It is not possible to lose data as a result of the crashes, AFAIK, because
--test ignores any file arguments that are also in the command.
Gale
Post by James Crook
Paul,
We can release fine with it unfixed.
IF you have a branch with a fix in, I am 90% likely to apply it.
A fix is likely to be safe.
I don't think we are ready to start doing RCs.
http://bugzilla.audacityteam.org/show_bug.cgi?id=1567 gives a reason not
to yet.
I'm also uneasy about the number of quite serious bugs that we're only
http://bugzilla.audacityteam.org/show_bug.cgi?id=1560
I need to put the windows wxfixes in with the mac wxfixes in our
wxwidgets repo too.
--James.
Post by Paul Licameli
If you start Audacity from the command line with option -t, which
brings up
Post by James Crook
Post by Paul Licameli
the benchmark dialog, then the application no longer exits after the
dialog
Post by James Crook
Post by Paul Licameli
closes.
This can be easily fixed. Is this very important?
PRL
------------------------------------------------------------
------------------
Post by James Crook
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Paul Licameli
2016-12-26 01:22:06 UTC
Permalink
I did not mean to allude to bug 1488, but it happens that the fix for 1561
also touches code that invokes the benchmark dialog.

So let's understand the history of 1488:

Reported by Gale as a crash (and it was a consequence of some of my work on
memory managment, and I think not specific to any operating system or even
platform)
Fixed by me on 20 August
https://github.com/audacity/audacity/commit/5761972dfaae0882635004570133331ef88d47cf
Tried again by Gale on 23 August, and reopened

So: it is possible that the commit I made was sufficient to fix it on El
Capitan, where I tried it, but not sufficient to fix it on Windows, or on
Snow Leopard, for reasons related to the crash in 1561.

So it may now be non-crashing in present HEAD. But the behavior is
slightly wrong, because closing the benchmark previously ended the program,
but in HEAD it now leaves the application open.

So the recent change in my fork may give the completely correct behavior,
which is:

Invoking the benchmark from command line causes the application to quit,
without crashing, when the benchmark dialog closes.

PRL
Post by Gale Andrews
I see I am not the only one failing to observe the season.
http://bugzilla.audacityteam.org/show_bug.cgi?id=1488 .
For me, on Mac and Linux release builds, Audacity crashes after closing
Benchmark started from the Terminal. But I expected Audacity to stay open,
and so therefore does the bug report. I don't care too much if it can be made
to quit cleanly, as long as the documentation says that Audacity quit is
supposed to happen (it doesn't say so at help/audacity.1).
Does Audacity stay open if you use Help > Run Benchmark... from
inside a debug build then close the Benchmark? I don't have a recent
debug build.
It is not possible to lose data as a result of the crashes, AFAIK, because
--test ignores any file arguments that are also in the command.
Gale
Post by James Crook
Paul,
We can release fine with it unfixed.
IF you have a branch with a fix in, I am 90% likely to apply it.
A fix is likely to be safe.
I don't think we are ready to start doing RCs.
http://bugzilla.audacityteam.org/show_bug.cgi?id=1567 gives a reason not
to yet.
I'm also uneasy about the number of quite serious bugs that we're only
http://bugzilla.audacityteam.org/show_bug.cgi?id=1560
I need to put the windows wxfixes in with the mac wxfixes in our
wxwidgets repo too.
--James.
Post by Paul Licameli
If you start Audacity from the command line with option -t, which
brings up
Post by James Crook
Post by Paul Licameli
the benchmark dialog, then the application no longer exits after the
dialog
Post by James Crook
Post by Paul Licameli
closes.
This can be easily fixed. Is this very important?
PRL
------------------------------------------------------------
------------------
Post by James Crook
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Gale Andrews
2016-12-26 19:16:27 UTC
Permalink
Thanks, Paul.

Yes bug 1488 does not exist any more, but the bug had not been commented
to state that. I resolved 1488 now.

I notice on a Windows debug build I made on 08 Sep 2015 that

audacity --t

let Audacity remain open after closing the Benchmark. I feel exiting Audacity
is unexpected and might look like a crash, so when you commit this I again
suggest you update the command-line documentation in help/audacity.1
to say that exit is the correct behaviour.


Thanks

Gale
Post by Paul Licameli
I did not mean to allude to bug 1488, but it happens that the fix for 1561
also touches code that invokes the benchmark dialog.
Reported by Gale as a crash (and it was a consequence of some of my work on
memory managment, and I think not specific to any operating system or even
platform)
Fixed by me on 20 August
https://github.com/audacity/audacity/commit/5761972dfaae0882635004570133331ef88d47cf
Tried again by Gale on 23 August, and reopened
So: it is possible that the commit I made was sufficient to fix it on El
Capitan, where I tried it, but not sufficient to fix it on Windows, or on
Snow Leopard, for reasons related to the crash in 1561.
So it may now be non-crashing in present HEAD. But the behavior is slightly
wrong, because closing the benchmark previously ended the program, but in
HEAD it now leaves the application open.
So the recent change in my fork may give the completely correct behavior,
Invoking the benchmark from command line causes the application to quit,
without crashing, when the benchmark dialog closes.
PRL
Post by Gale Andrews
I see I am not the only one failing to observe the season.
http://bugzilla.audacityteam.org/show_bug.cgi?id=1488 .
For me, on Mac and Linux release builds, Audacity crashes after closing
Benchmark started from the Terminal. But I expected Audacity to stay open,
and so therefore does the bug report. I don't care too much if it can be made
to quit cleanly, as long as the documentation says that Audacity quit is
supposed to happen (it doesn't say so at help/audacity.1).
Does Audacity stay open if you use Help > Run Benchmark... from
inside a debug build then close the Benchmark? I don't have a recent
debug build.
It is not possible to lose data as a result of the crashes, AFAIK, because
--test ignores any file arguments that are also in the command.
Gale
Post by James Crook
Paul,
We can release fine with it unfixed.
IF you have a branch with a fix in, I am 90% likely to apply it.
A fix is likely to be safe.
I don't think we are ready to start doing RCs.
http://bugzilla.audacityteam.org/show_bug.cgi?id=1567 gives a reason not
to yet.
I'm also uneasy about the number of quite serious bugs that we're only
http://bugzilla.audacityteam.org/show_bug.cgi?id=1560
I need to put the windows wxfixes in with the mac wxfixes in our
wxwidgets repo too.
--James.
Post by Paul Licameli
If you start Audacity from the command line with option -t, which brings up
the benchmark dialog, then the application no longer exits after the dialog
closes.
This can be easily fixed. Is this very important?
PRL
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Paul Licameli
2016-12-26 19:37:56 UTC
Permalink
What should be correct behavior?

I noticed I made an unintended change in behavior. But perhaps you think
the new behavior is right, so my addendum to the fix should not be taken.

PRL
Post by Gale Andrews
Thanks, Paul.
Yes bug 1488 does not exist any more, but the bug had not been commented
to state that. I resolved 1488 now.
I notice on a Windows debug build I made on 08 Sep 2015 that
audacity --t
let Audacity remain open after closing the Benchmark. I feel exiting Audacity
is unexpected and might look like a crash, so when you commit this I again
suggest you update the command-line documentation in help/audacity.1
to say that exit is the correct behaviour.
Thanks
Gale
Post by Paul Licameli
I did not mean to allude to bug 1488, but it happens that the fix for
1561
Post by Paul Licameli
also touches code that invokes the benchmark dialog.
Reported by Gale as a crash (and it was a consequence of some of my work
on
Post by Paul Licameli
memory managment, and I think not specific to any operating system or
even
Post by Paul Licameli
platform)
Fixed by me on 20 August
https://github.com/audacity/audacity/commit/
5761972dfaae0882635004570133331ef88d47cf
Post by Paul Licameli
Tried again by Gale on 23 August, and reopened
So: it is possible that the commit I made was sufficient to fix it on El
Capitan, where I tried it, but not sufficient to fix it on Windows, or on
Snow Leopard, for reasons related to the crash in 1561.
So it may now be non-crashing in present HEAD. But the behavior is
slightly
Post by Paul Licameli
wrong, because closing the benchmark previously ended the program, but in
HEAD it now leaves the application open.
So the recent change in my fork may give the completely correct behavior,
Invoking the benchmark from command line causes the application to quit,
without crashing, when the benchmark dialog closes.
PRL
Post by Gale Andrews
I see I am not the only one failing to observe the season.
http://bugzilla.audacityteam.org/show_bug.cgi?id=1488 .
For me, on Mac and Linux release builds, Audacity crashes after closing
Benchmark started from the Terminal. But I expected Audacity to stay
open,
Post by Paul Licameli
Post by Gale Andrews
and so therefore does the bug report. I don't care too much if it can be made
to quit cleanly, as long as the documentation says that Audacity quit is
supposed to happen (it doesn't say so at help/audacity.1).
Does Audacity stay open if you use Help > Run Benchmark... from
inside a debug build then close the Benchmark? I don't have a recent
debug build.
It is not possible to lose data as a result of the crashes, AFAIK,
because
Post by Paul Licameli
Post by Gale Andrews
--test ignores any file arguments that are also in the command.
Gale
Post by James Crook
Paul,
We can release fine with it unfixed.
IF you have a branch with a fix in, I am 90% likely to apply it.
A fix is likely to be safe.
I don't think we are ready to start doing RCs.
http://bugzilla.audacityteam.org/show_bug.cgi?id=1567 gives a reason
not
Post by Paul Licameli
Post by Gale Andrews
Post by James Crook
to yet.
I'm also uneasy about the number of quite serious bugs that we're only
http://bugzilla.audacityteam.org/show_bug.cgi?id=1560
I need to put the windows wxfixes in with the mac wxfixes in our
wxwidgets repo too.
--James.
Post by Paul Licameli
If you start Audacity from the command line with option -t, which brings up
the benchmark dialog, then the application no longer exits after the dialog
closes.
This can be easily fixed. Is this very important?
PRL
------------------------------------------------------------
------------------
Post by Paul Licameli
Post by Gale Andrews
Post by James Crook
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
Post by Paul Licameli
Post by Gale Andrews
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
Post by Paul Licameli
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Gale Andrews
2016-12-26 19:55:29 UTC
Permalink
I'm +1 on closing Benchmark keeping Audacity open, and even
having Audacity open projects or import files if those are passed
along with --t in the same command. Apparently we had code
that made Audacity close projects before running Benchmark,
but that code is commented out.

My only strong view though is that audacity.1 should be clear
what happens, whatever we decide. That file implies now that
--t only runs the Benchmark in development builds, which is not
the case.


Gale
Post by Paul Licameli
What should be correct behavior?
I noticed I made an unintended change in behavior. But perhaps you think
the new behavior is right, so my addendum to the fix should not be taken.
PRL
Post by Gale Andrews
Thanks, Paul.
Yes bug 1488 does not exist any more, but the bug had not been commented
to state that. I resolved 1488 now.
I notice on a Windows debug build I made on 08 Sep 2015 that
audacity --t
let Audacity remain open after closing the Benchmark. I feel exiting Audacity
is unexpected and might look like a crash, so when you commit this I again
suggest you update the command-line documentation in help/audacity.1
to say that exit is the correct behaviour.
Thanks
Gale
Post by Paul Licameli
I did not mean to allude to bug 1488, but it happens that the fix for 1561
also touches code that invokes the benchmark dialog.
Reported by Gale as a crash (and it was a consequence of some of my work on
memory managment, and I think not specific to any operating system or even
platform)
Fixed by me on 20 August
https://github.com/audacity/audacity/commit/5761972dfaae0882635004570133331ef88d47cf
Tried again by Gale on 23 August, and reopened
So: it is possible that the commit I made was sufficient to fix it on El
Capitan, where I tried it, but not sufficient to fix it on Windows, or on
Snow Leopard, for reasons related to the crash in 1561.
So it may now be non-crashing in present HEAD. But the behavior is slightly
wrong, because closing the benchmark previously ended the program, but in
HEAD it now leaves the application open.
So the recent change in my fork may give the completely correct behavior,
Invoking the benchmark from command line causes the application to quit,
without crashing, when the benchmark dialog closes.
PRL
Post by Gale Andrews
I see I am not the only one failing to observe the season.
http://bugzilla.audacityteam.org/show_bug.cgi?id=1488 .
For me, on Mac and Linux release builds, Audacity crashes after closing
Benchmark started from the Terminal. But I expected Audacity to stay open,
and so therefore does the bug report. I don't care too much if it can
be
made
to quit cleanly, as long as the documentation says that Audacity quit is
supposed to happen (it doesn't say so at help/audacity.1).
Does Audacity stay open if you use Help > Run Benchmark... from
inside a debug build then close the Benchmark? I don't have a recent
debug build.
It is not possible to lose data as a result of the crashes, AFAIK, because
--test ignores any file arguments that are also in the command.
Gale
Post by James Crook
Paul,
We can release fine with it unfixed.
IF you have a branch with a fix in, I am 90% likely to apply it.
A fix is likely to be safe.
I don't think we are ready to start doing RCs.
http://bugzilla.audacityteam.org/show_bug.cgi?id=1567 gives a reason not
to yet.
I'm also uneasy about the number of quite serious bugs that we're only
http://bugzilla.audacityteam.org/show_bug.cgi?id=1560
I need to put the windows wxfixes in with the mac wxfixes in our
wxwidgets repo too.
--James.
Post by Paul Licameli
If you start Audacity from the command line with option -t, which brings up
the benchmark dialog, then the application no longer exits after the dialog
closes.
This can be easily fixed. Is this very important?
PRL
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Loading...