Discussion:
[Audacity-devel] Time shifting clips using the keyboard and the TrackPanel refactor
David Bailes
2017-04-01 11:52:28 UTC
Permalink
Paul, as I've mentioned a few times recently I've been working on making
clips accessible for keyboard users.
My code for the time shifting clips using the keyboard makes use of
existing code in TrackPanel, which you are planning on moving.
To be more specific, for each of the functions TrackPanel::DoSlide and
TrackPanel::StartSlide, I've created a function for some of the
functionality, which is used both by the Mouse code, and by my keyboard
code.
My current work for this is available here:
https://github.com/DavidBailes/audacity/commit/50d9037b0aa48916c258f6eb04ba4503346cce10

When are you planning to commit your TrackPanel refactor? Does your current
refactor easily allow, or is easily modifiable to allow, the time shifting
of clips using either the mouse or the keyboard?
If the time shifting of clips isn't easily achievable using your current
TrackPanel refactor, then I'd prefer to commit my code first, so that you
see what changes are needed to your refactor.

David.
Paul Licameli
2017-04-01 15:08:32 UTC
Permalink
David, do what you wish, and let me figure out the merge.

I have decided that exception handling is my near priority and I do not
want to delay other developments.

PRL
Post by David Bailes
Paul, as I've mentioned a few times recently I've been working on making
clips accessible for keyboard users.
My code for the time shifting clips using the keyboard makes use of
existing code in TrackPanel, which you are planning on moving.
To be more specific, for each of the functions TrackPanel::DoSlide and
TrackPanel::StartSlide, I've created a function for some of the
functionality, which is used both by the Mouse code, and by my keyboard
code.
https://github.com/DavidBailes/audacity/commit/
50d9037b0aa48916c258f6eb04ba4503346cce10
When are you planning to commit your TrackPanel refactor? Does your
current refactor easily allow, or is easily modifiable to allow, the time
shifting of clips using either the mouse or the keyboard?
If the time shifting of clips isn't easily achievable using your current
TrackPanel refactor, then I'd prefer to commit my code first, so that you
see what changes are needed to your refactor.
David.
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
David Bailes
2017-04-01 16:11:18 UTC
Permalink
Post by Paul Licameli
David, do what you wish, and let me figure out the merge.
thanks,
David.
Post by Paul Licameli
I have decided that exception handling is my near priority and I do not
want to delay other developments.
PRL
Post by David Bailes
Paul, as I've mentioned a few times recently I've been working on making
clips accessible for keyboard users.
My code for the time shifting clips using the keyboard makes use of
existing code in TrackPanel, which you are planning on moving.
To be more specific, for each of the functions TrackPanel::DoSlide and
TrackPanel::StartSlide, I've created a function for some of the
functionality, which is used both by the Mouse code, and by my keyboard
code.
https://github.com/DavidBailes/audacity/commit/50d9037b0aa48
916c258f6eb04ba4503346cce10
When are you planning to commit your TrackPanel refactor? Does your
current refactor easily allow, or is easily modifiable to allow, the time
shifting of clips using either the mouse or the keyboard?
If the time shifting of clips isn't easily achievable using your current
TrackPanel refactor, then I'd prefer to commit my code first, so that you
see what changes are needed to your refactor.
David.
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Loading...