[Audacity-devel] Patching wxWidgets?

Discussion:

Paul Licameli

2016-06-18 20:14:23 UTC

I see that we sometimes specify a patch of wxWidgets source code as a step
in the build process.

Might we do that for the 2.1.3 release if it is necessary to fix high
priority bugs?

I am concerned for Mac especially. Several high priority bugs were
regressions between 2.1.1 and 2.1.2 that are seemingly the fault of
wxWidgets, not our code.

For one, there is this patch which may fix many problems with tab
navigation:
http://trac.wxwidgets.org/attachment/ticket/17341/tab_navigation_fix_general.patch

For another there is this bug:

http://bugzilla.audacityteam.org/show_bug.cgi?id=1338

I don't know yet what might patch it, but I have cloned the wxWidgets git
repository and I am bisecting that. I know things went wrong somewhere
between 3.0.0 and 3.0.1. I might even discover a bug fix for wxWidgets.

PRL

James Crook

2016-06-18 20:50:57 UTC

Permalink

Post by Paul Licameli
I see that we sometimes specify a patch of wxWidgets source code as a
step in the build process.
Might we do that for the 2.1.3 release if it is necessary to fix high
priority bugs?

Yes. If I am RM we would do that where there is a clear good fix and
the bug is serious enough to merit it.

If 3.1.1 is out soon, I would also be very tempted to shift to it -
though not 3.1.0 as I don't see enough gain.
This is based on my understanding of what wxWidgets mean by a
'development release' (as stated by Vadz at
https://github.com/wxWidgets/wxWidgets/releases)

--James.

Post by Paul Licameli
I am concerned for Mac especially. Several high priority bugs were
regressions between 2.1.1 and 2.1.2 that are seemingly the fault of
wxWidgets, not our code.
For one, there is this patch which may fix many problems with tab
http://trac.wxwidgets.org/attachment/ticket/17341/tab_navigation_fix_general.patch
http://bugzilla.audacityteam.org/show_bug.cgi?id=1338
I don't know yet what might patch it, but I have cloned the wxWidgets
git repository and I am bisecting that. I know things went wrong
somewhere between 3.0.0 and 3.0.1. I might even discover a bug fix
for wxWidgets.
PRL

Paul Licameli

2016-06-18 20:59:09 UTC

Permalink

I say again, a bonus in 3.1.0 and later is that we can implement the pinch
and spread gestures on the mac touch pad.

PRL

Post by James Crook

Yes. If I am RM we would do that where there is a clear good fix and
the bug is serious enough to merit it.
If 3.1.1 is out soon, I would also be very tempted to shift to it -
though not 3.1.0 as I don't see enough gain.
This is based on my understanding of what wxWidgets mean by a
'development release' (as stated by Vadz at
https://github.com/wxWidgets/wxWidgets/releases)
--James.

http://trac.wxwidgets.org/attachment/ticket/17341/tab_navigation_fix_general.patch

Post by Paul Licameli
http://bugzilla.audacityteam.org/show_bug.cgi?id=1338
I don't know yet what might patch it, but I have cloned the wxWidgets
git repository and I am bisecting that. I know things went wrong
somewhere between 3.0.0 and 3.0.1. I might even discover a bug fix
for wxWidgets.
PRL

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and
traffic
patterns at an interface-level. Reveals which users, apps, and protocols
are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning
reports. http://sdm.link/zohomanageengine
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Paul Licameli

2016-06-18 22:22:27 UTC

Permalink

Guess what? I successfully used git bisect, not on our code, but on
wxWidgets, to prove that this innocent looking one-line change:

https://github.com/wxWidgets/wxWidgets/commit/606403fd33686523cfd9808905b92b9f2eb7b95d

caused this P2 Mac-only bug:

http://bugzilla.audacityteam.org/show_bug.cgi?id=1338

So there's a candidate for a patch, and maybe we should tell the wxWidgets
guys about it.

This was stupid brute-force hunting for a bug in code I don't understand at
all, but still it feels like a valuable experience. I know I can bisect
wxWidgets again if I need to.

PRL

Post by Paul Licameli
I say again, a bonus in 3.1.0 and later is that we can implement the pinch
and spread gestures on the mac touch pad.
PRL

Post by James Crook

Yes. If I am RM we would do that where there is a clear good fix and
the bug is serious enough to merit it.
If 3.1.1 is out soon, I would also be very tempted to shift to it -
though not 3.1.0 as I don't see enough gain.
This is based on my understanding of what wxWidgets mean by a
'development release' (as stated by Vadz at
https://github.com/wxWidgets/wxWidgets/releases)
--James.

http://trac.wxwidgets.org/attachment/ticket/17341/tab_navigation_fix_general.patch

Vaughan Johnson

2016-08-15 13:47:03 UTC

Permalink

Post by Paul Licameli
Guess what? I successfully used git bisect, not on our code, but on
https://github.com/wxWidgets/wxWidgets/commit/
606403fd33686523cfd9808905b92b9f2eb7b95d
http://bugzilla.audacityteam.org/show_bug.cgi?id=1338
So there's a candidate for a patch, and maybe we should tell the wxWidgets
guys about it.
This was stupid brute-force hunting for a bug in code I don't understand
at all, but still it feels like a valuable experience. I know I can bisect
wxWidgets again if I need to.
PRL

Post by Paul Licameli
I say again, a bonus in 3.1.0 and later is that we can implement the
pinch and spread gestures on the mac touch pad.
PRL

Post by James Crook

Yes. If I am RM we would do that where there is a clear good fix and
the bug is serious enough to merit it.
If 3.1.1 is out soon, I would also be very tempted to shift to it -
though not 3.1.0 as I don't see enough gain.
This is based on my understanding of what wxWidgets mean by a
'development release' (as stated by Vadz at
https://github.com/wxWidgets/wxWidgets/releases)
--James.

navigation_fix_general.patch

------------------------------------------------------------
------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and
traffic
patterns at an interface-level. Reveals which users, apps, and protocols
are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning
reports. http://sdm.link/zohomanageengine
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel