[Audacity-devel] Assertion failure because of Dark Audacity

Discussion:

Paul Licameli

2017-04-28 18:35:26 UTC

Steve the Fiddle

2017-04-28 19:55:38 UTC

I see the assert on Linux, but only the first time that the Mixer
Board is opened. It is non-fatal - click "Continue" and the Mixer
Board opens.

Steve

Post by Paul Licameli
New project. Make a mono wave track. View the Mixer Board. An assertion
fails, at least on macOS.
I bisected this to this commit; but to compile it on macOs I must add
#include <wx/dcmemory.h>
to AColor.cpp.
commit 18422d0e5f4e01e026ffa31a9b7e24171f1b8a2c
Date: Thu Aug 18 22:17:05 2016 +0100
Set colours for MixerBoard
PRL
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Gale Andrews

2017-04-28 20:08:36 UTC

Permalink

Yes I get an assertion

" ./src/gtk/dcclient.cpp(1831): assert "IsOk()" failed in
SetTextForeground(): invalid window dc"

on Ubuntu 14.04 in a release build (because of the Wx debug level
on Linux).

It does not happen with a stereo track, and does not happen in 2.1.3.

Gale

Paul Licameli

2017-04-29 11:12:23 UTC

Permalink

I do not see it behaving differently for stereo tracks.

If the assertion dialog is dismissed once with the ESC key, it will not
reucr until the program is restarted.

Gale, did you really try repeating the variation of mono and stereo only
after a program restart?

PRL

Post by Gale Andrews
Yes I get an assertion
" ./src/gtk/dcclient.cpp(1831): assert "IsOk()" failed in
SetTextForeground(): invalid window dc"
on Ubuntu 14.04 in a release build (because of the Wx debug level
on Linux).
It does not happen with a stereo track, and does not happen in 2.1.3.
Gale

Post by Paul Licameli
New project. Make a mono wave track. View the Mixer Board. An

assertion

Post by Paul Licameli
fails, at least on macOS.
I bisected this to this commit; but to compile it on macOs I must add
#include <wx/dcmemory.h>
to AColor.cpp.
commit 18422d0e5f4e01e026ffa31a9b7e24171f1b8a2c
Date: Thu Aug 18 22:17:05 2016 +0100
Set colours for MixerBoard
PRL
------------------------------------------------------------

------------------

Post by Paul Licameli
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Gale Andrews

2017-04-29 17:05:52 UTC

Permalink

Unfortunately I did not see Steve's post that the assertion only occurs
on first use in a session until after I had posted my reply. So you're
correct, stereo or mono track makes no difference.

Is your https://github.com/audacity/audacity/commit/a3b9dbd
a fix for this? If so, it is always good to say in the commit message
if an assertion is fixed.

On Linux, ESC in an assertion dialogue acts like Stop so force quits
Audacity. One must press "Continue" to prevent Audacity force quitting.

Gale

Post by Paul Licameli
I do not see it behaving differently for stereo tracks.
If the assertion dialog is dismissed once with the ESC key, it will not
reucr until the program is restarted.
Gale, did you really try repeating the variation of mono and stereo only
after a program restart?
PRL

Paul Licameli

2017-04-29 17:24:47 UTC

Permalink

That commit is not a fix for this.

I am expecting James to figure this out.

PRL

Post by Gale Andrews
Unfortunately I did not see Steve's post that the assertion only occurs
on first use in a session until after I had posted my reply. So you're
correct, stereo or mono track makes no difference.
Is your https://github.com/audacity/audacity/commit/a3b9dbd
a fix for this? If so, it is always good to say in the commit message
if an assertion is fixed.
On Linux, ESC in an assertion dialogue acts like Stop so force quits
Audacity. One must press "Continue" to prevent Audacity force quitting.
Gale

------------------

Post by Paul Licameli

Post by Gale Andrews

------------------------------------------------------------

------------------

Post by Paul Licameli

Post by Gale Andrews
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

------------------------------------------------------------

------------------

Cliff Scott

2017-04-28 21:38:22 UTC

Permalink

Paul,

Are you saying it was caused by a commit on Aug 18, 2016? I compiled April 22, 2017 and it does not cause an assertion here on 10.12.4. Tried it two ways just in case I made a difference. Also ok on Audacity 2.1.3

1. The steps I used were:

1. Open Audacity, record a short segment, 10 sec or so, View the Mixer board and all is ok.

2. Open Audacity, Open new project, Add new track from menu, View Mixer board. All is still ok. Works for multi tracks as well.

Maybe I don't understand what you mean by "An assertion fails". I'm assuming you mean that either Audacity crashes or errors show up in the log or Console.

I did find this:

Apr 28 16:34:35 Cliffs-MBP Audacity[88975]: BUG in libdispatch client: kevent[EVFILT_MACHPORT] monitored resource vanished before the source cancel handler was invoked

Cliff

New project. Make a mono wave track. View the Mixer Board. An assertion fails, at least on macOS.
I bisected this to this commit; but to compile it on macOs I must add
#include <wx/dcmemory.h>
to AColor.cpp.
commit 18422d0e5f4e01e026ffa31a9b7e24171f1b8a2c
Date: Thu Aug 18 22:17:05 2016 +0100
Set colours for MixerBoard
PRL
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Paul Licameli

2017-04-28 21:44:10 UTC

Permalink

Cliff, to see the symptom, you must make a debug build.

I don't know if it happens on Windows too.

PRL

Post by Cliff Scott
Paul,
Are you saying it was caused by a commit on Aug 18, 2016? I compiled April
22, 2017 and it does not cause an assertion here on 10.12.4. Tried it two
ways just in case I made a difference. Also ok on Audacity 2.1.3
1. Open Audacity, record a short segment, 10 sec or so, View the Mixer board and all is ok.
2. Open Audacity, Open new project, Add new track from menu, View Mixer
board. All is still ok. Works for multi tracks as well.
Maybe I don't understand what you mean by "An assertion fails". I'm
assuming you mean that either Audacity crashes or errors show up in the log
or Console.
kevent[EVFILT_MACHPORT] monitored resource vanished before the source
cancel handler was invoked
Cliff
New project. Make a mono wave track. View the Mixer Board. An assertion
fails, at least on macOS.
I bisected this to this commit; but to compile it on macOs I must add
#include <wx/dcmemory.h>
to AColor.cpp.
commit 18422d0e5f4e01e026ffa31a9b7e24171f1b8a2c
Date: Thu Aug 18 22:17:05 2016 +0100
Set colours for MixerBoard
PRL
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot______
_________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Cliff Scott

2017-04-28 22:42:04 UTC

Permalink

Ok. Thought I probably didn't understand something.

Cliff

Post by Paul Licameli
Cliff, to see the symptom, you must make a debug build.
I don't know if it happens on Windows too.
PRL
Paul,
Are you saying it was caused by a commit on Aug 18, 2016? I compiled April 22, 2017 and it does not cause an assertion here on 10.12.4. Tried it two ways just in case I made a difference. Also ok on Audacity 2.1.3
1. Open Audacity, record a short segment, 10 sec or so, View the Mixer board and all is ok.
2. Open Audacity, Open new project, Add new track from menu, View Mixer board. All is still ok. Works for multi tracks as well.
Maybe I don't understand what you mean by "An assertion fails". I'm assuming you mean that either Audacity crashes or errors show up in the log or Console.
Apr 28 16:34:35 Cliffs-MBP Audacity[88975]: BUG in libdispatch client: kevent[EVFILT_MACHPORT] monitored resource vanished before the source cancel handler was invoked
Cliff

New project. Make a mono wave track. View the Mixer Board. An assertion fails, at least on macOS.
I bisected this to this commit; but to compile it on macOs I must add
#include <wx/dcmemory.h>
to AColor.cpp.
commit 18422d0e5f4e01e026ffa31a9b7e24171f1b8a2c
Date: Thu Aug 18 22:17:05 2016 +0100
Set colours for MixerBoard
PRL
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org <http://slashdot.org/>! http://sdm.link/slashdot_______________________________________________ <http://sdm.link/slashdot_______________________________________________>
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot <http://sdm.link/slashdot>
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel <https://lists.sourceforge.net/lists/listinfo/audacity-devel>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel