[Audacity-devel] Screen reader focus, and screenshot

Post by Paul Licameli
Of interest to David and James.
Regarding my recent commits
134c1ff47a7276411cfa804a95fd6909ea20145b
c38efc1fcda278bcdac95758d4eb46afe59e5b5d
David, I changed the rectangle drawn around individual tracks by screen
readers. Formerly it did not follow Audacity's own yellow focus rectangle
as exactly as it does now. I have tried it with macOs VoiceOver. In my
opinion it looks better. But your opinion will rule. You may wish to
adjust the constant dx in TrackPanelAx::GetLocation.
James, I rewrote some things in Screenshot.cpp which you also recently
changed. I intend no visible changes of behavior. You may wish to review.

Thanks. Have reviewed, and it does not overlap with the changes I have
been making there and all looks fine.
--James.

Paul Licameli

2017-06-04 16:11:32 UTC

Post by James Crook

Thanks. Have reviewed, and it does not overlap with the changes I have
been making there and all looks fine.
--James.

I raised a fussy question in comments, whether we capture one pixel too
much left and right sides each.
PRL

Post by James Crook

------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

David Bailes

2017-06-05 14:56:59 UTC

I've attached a couple of screenshots using narrator on Windows 10. I've
also checked with ZoomText, a popular screen magnifier, and the results are
similar.
With your changes, the left and top edges are worse, but the right edge is
better.
What were the differences like on macOS?
On Windows, it was probably better as it was.

David.

Post by Paul Licameli
James, I rewrote some things in Screenshot.cpp which you also recently
changed. I intend no visible changes of behavior. You may wish to review.
PRL
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Paul Licameli

2017-06-05 19:52:05 UTC

4b4bece makes a slight change that should improve these pictures.

It leaves it unchanged on Mac.

Voice Over seems to draw a thinner rectangle, three pixels thick, white
around black around white, as around the top track in this picture, which
looks good to me.

PRL

David Bailes

2017-06-06 12:38:34 UTC

Post by Paul Licameli
4b4bece makes a slight change that should improve these pictures.

thanks, it's now fine.

Post by Paul Licameli
It leaves it unchanged on Mac.
Voice Over seems to draw a thinner rectangle, three pixels thick, white
around black around white, as around the top track in this picture, which
looks good to me.

that looks OK as well, though hopefully in the future apple will allow
users to change the focus indication to something more prominent,

David.

I've attached a couple of screenshots using narrator on Windows 10. I've
also checked with ZoomText, a popular screen magnifier, and the results are
similar.
With your changes, the left and top edges are worse, but the right edge
is better.
What were the differences like on macOS?
On Windows, it was probably better as it was.
David.

Paul Licameli

2017-06-06 16:17:11 UTC

Post by Paul Licameli
4b4bece makes a slight change that should improve these pictures.

thanks, it's now fine.

that looks OK as well, though hopefully in the future apple will allow
users to change the focus indication to something more prominent,
David.

Maybe there is already. I have not explored all the things in VoiceOver's
menus. I just show you the default.

I just discovered that shfit+control+alt+[ or ] allows you to increase or
decrease a magnification applied to the focused item. That's nice.

Do you have access to a Mac?

PRL

I've attached a couple of screenshots using narrator on Windows 10. I've
also checked with ZoomText, a popular screen magnifier, and the results are
similar.
With your changes, the left and top edges are worse, but the right edge
is better.
What were the differences like on macOS?
On Windows, it was probably better as it was.
David.

David Bailes

2017-06-07 10:22:37 UTC

Post by Paul Licameli

Post by Paul Licameli
4b4bece makes a slight change that should improve these pictures.

thanks, it's now fine.

that looks OK as well, though hopefully in the future apple will allow
users to change the focus indication to something more prominent,
David.

Maybe there is already. I have not explored all the things in VoiceOver's
menus. I just show you the default.
I just discovered that shfit+control+alt+[ or ] allows you to increase or
decrease a magnification applied to the focused item. That's nice.
Do you have access to a Mac?

Unfortunately, I don't have immediate access to one,

David.