Discussion:
[Audacity-devel] Bug swapping channels, due to James
Paul Licameli
2017-04-24 21:23:29 UTC
Permalink
Create a stereo track. Then swap its channels. The pan slider goes to the
far right, when it should remain centered.

This bug bisects to:

ebff4db80a215fd7779a2476c954506044aeaa8e

The commit changes
if (!stereo)
to
if (stereo)

in two places, which I think causes the bug, but this negation of the
condition doesn't look like an accident. Explain, was it for some reason
on purpose?

PRL
James Crook
2017-04-24 22:28:05 UTC
Permalink
Thanks. Fixed
https://github.com/audacity/audacity/commit/de798b17d5c48202e5aae0a590364c45129dcaa4

The inside of those two tests changed as well, and that was for the
split stereo to mono and split stereo commands.

--James.
Post by Paul Licameli
Create a stereo track. Then swap its channels. The pan slider goes to the
far right, when it should remain centered.
ebff4db80a215fd7779a2476c954506044aeaa8e
The commit changes
if (!stereo)
to
if (stereo)
in two places, which I think causes the bug, but this negation of the
condition doesn't look like an accident. Explain, was it for some reason
on purpose?
PRL
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel
Loading...