[Audacity-devel] Wrong return values and Mac build, and an error in wxWidgets

Discussion:

Paul Licameli

2017-06-25 20:04:07 UTC

I fixed the recent errors I introduced into the Windows build, because
functions had wrongly typed returns.

I figured out how to change the settings for Mac build so that such errors
are not forgiven.

I fixed a few errors this uncovered.

But guess what? It also uncovers a non-void function that returns nothing,
in one of the wxWidgets headers!

For that reason, I reverted the change in the Xcode project, but now I may
want to make a one line change to our custom build of wxWidgets headers,
just to fix this.

PRL

Martyn Shaw

2017-06-25 22:58:37 UTC

Permalink

Hi Paul

Have you reported back to the wx folk? It might be useful in the long run.

TTFN
Martyn

Post by Paul Licameli
I fixed the recent errors I introduced into the Windows build, because
functions had wrongly typed returns.
I figured out how to change the settings for Mac build so that such errors
are not forgiven.
I fixed a few errors this uncovered.
But guess what? It also uncovers a non-void function that returns
nothing, in one of the wxWidgets headers!
For that reason, I reverted the change in the Xcode project, but now I may
want to make a one line change to our custom build of wxWidgets headers,
just to fix this.
PRL
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Paul Licameli

2017-06-26 16:18:53 UTC

Permalink

Oh, this is embarrassing: That error was introduced only in one of the
wxWidgets patches that I wrote for our previous release. It's not in their
source!

PRL

Post by Martyn Shaw
Hi Paul
Have you reported back to the wx folk? It might be useful in the long run.
TTFN
Martyn

Post by Paul Licameli
I fixed the recent errors I introduced into the Windows build, because
functions had wrongly typed returns.
I figured out how to change the settings for Mac build so that such
errors are not forgiven.
I fixed a few errors this uncovered.
But guess what? It also uncovers a non-void function that returns
nothing, in one of the wxWidgets headers!
For that reason, I reverted the change in the Xcode project, but now I
may want to make a one line change to our custom build of wxWidgets
headers, just to fix this.
PRL
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Paul Licameli

2017-06-26 16:23:49 UTC

Permalink

Post by Paul Licameli
Oh, this is embarrassing: That error was introduced only in one of the
wxWidgets patches that I wrote for our previous release. It's not in their
source!
PRL

I added this inline function to a header file, and I made its return type
bool, but returned no value, but neither did I use the return value
anywhere. So it is a harmless error. But I must fix it if I want to
change Mac build settings so that it can catch errors of this kind.

PRL

Post by Paul Licameli

Post by Martyn Shaw
Hi Paul
Have you reported back to the wx folk? It might be useful in the long run.
TTFN
Martyn

Post by Paul Licameli
I fixed the recent errors I introduced into the Windows build, because
functions had wrongly typed returns.
I figured out how to change the settings for Mac build so that such
errors are not forgiven.
I fixed a few errors this uncovered.
But guess what? It also uncovers a non-void function that returns
nothing, in one of the wxWidgets headers!
For that reason, I reverted the change in the Xcode project, but now I
may want to make a one line change to our custom build of wxWidgets
headers, just to fix this.
PRL
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel

Martyn Shaw

2017-06-26 16:31:11 UTC

Permalink

:-)

Post by Paul Licameli
Oh, this is embarrassing: That error was introduced only in one of the
wxWidgets patches that I wrote for our previous release. It's not in their
source!
PRL

Post by Martyn Shaw
Hi Paul
Have you reported back to the wx folk? It might be useful in the long run.
TTFN
Martyn

Post by Paul Licameli
I fixed the recent errors I introduced into the Windows build, because
functions had wrongly typed returns.
I figured out how to change the settings for Mac build so that such
errors are not forgiven.
I fixed a few errors this uncovered.
But guess what? It also uncovers a non-void function that returns
nothing, in one of the wxWidgets headers!
For that reason, I reverted the change in the Xcode project, but now I
may want to make a one line change to our custom build of wxWidgets
headers, just to fix this.
PRL
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
audacity-devel mailing list
https://lists.sourceforge.net/lists/listinfo/audacity-devel